Break out PDF 526v2 test

[acovrig]

Summary

• Break v2 526 PDF specs to separate file

Related issue(s)

• API-39275

Testing done

• New code is covered by unit tests

What areas of the site does it impact?

v2 526 request specs

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[github-actions]

1 Warning

⚠️

This PR changes 262 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files modules/claims_api/app/controllers/claims_api/v2/veterans/disability_compensation_controller.rb (+1/-1) modules/claims_api/spec/lib/claims_api/v2/disability_compensation_pdf_mapper_spec.rb (+2/-2) modules/claims_api/spec/requests/v2/veterans/526_spec.rb (+72/-184) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[github-actions]

Doesn't depend on instance state (maybe move it to another class?) - UtilityFunction

[github-actions]

Doesn't depend on instance state (maybe move it to another class?) - UtilityFunction

[stiehlrod]

@acovrig I don't see a replacement for the minimum validations spec, nor do I see a dup in the whole file, I am curious as why you think we don't need this test?

[acovrig]

It got renamed, sorry for the confusion

[rockwellwindsor-va]

Understand the nesting now on generatePDF, see the duplicate test, and thanks for cleaning up that method in the controller that I totally messed up.

Everything still looks covered and is still green