Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dangerfile updates for db migration #16511

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Dangerfile updates for db migration #16511

merged 2 commits into from
Apr 29, 2024

Conversation

rmtolmach
Copy link
Contributor

@rmtolmach rmtolmach commented Apr 25, 2024

Summary

I'm updating the Dangerbot message. One URL was bad and the message was partially inaccurate. Migrations ARE run automatically 🎉

Related issue(s)

I saw the need for this update while on support, so I'll link our support epic:

What areas of the site does it impact?

The Dangerbot message when someone submits a PR with db files + other files.

@RachalCassity RachalCassity self-assigned this Apr 26, 2024
@rmtolmach rmtolmach merged commit fe41990 into master Apr 29, 2024
23 checks passed
@rmtolmach rmtolmach deleted the dangerfile_updates branch April 29, 2024 20:41
gabezurita added a commit that referenced this pull request Apr 30, 2024
* master: (33 commits)
  [DBX-74810] Add flipper with LH BI api for 4142 (#16483)
  upadte param dig call (#16570)
  98 add code to poll average days (#16471)
  8147 claim model (#16525)
  Toxic Exposure: Save TE "Add Conditions" fields for future transformation (#16548)
  Revert "ClamAV in Containers (#15965)" (#16557)
  Dangerfile updates for db migration (#16511)
  API-35829-error_handling (#16522)
  add loggers to see what dd api call is doing in staging (#16539)
  8440: fix appointments contract schema (#16528)
  ClamAV in Containers (#15965)
  Protect against calling `.any?` on a non-array (#16547)
  BE | Ask VA Api: Refactor classes and specs (#16542)
  Added '10-10EZR' to the list of freeze schemas (#16478)
  Add prefill for 10-7959c (#16448)
  Bump shrine from 3.5.0 to 3.6.0 (#16532)
  change limit on place and location. update question number (#16537)
  Add words_to_remove for simple forms 21-0966 (#16477)
  updgrade sidekiq and super_diff (#16536)
  BE | Ask Va Api:  Update `Inquiries::Creator` `Correspondences::Creator` Error Handling (#16529)
  ...
stevenjcumming added a commit that referenced this pull request May 1, 2024
* prefer pdftk-java with debian bookworm

* 8440: fix appointments contract schema (#16528)

* add loggers to see what dd api call is doing in staging (#16539)

* API-35829-error_handling (#16522)

* Adds error handling for new synchronous endpoint. Iterates through errors and adds them to the ecss_response on the claim. Adds to the retry? method to check the evss_response for the error key.

* Addressese PR suggestions

* REmoves error message, and uses evss_response on the claim instead.

* Adds a save rigt after updating the status on the claim

* Adds several tests

* Alters a test to more accurately test the scenario IRL

* Dangerfile updates for db migration (#16511)

* Revert "ClamAV in Containers (#15965)" (#16557)

This reverts commit 0857270.

* Toxic Exposure: Save TE "Add Conditions" fields for future transformation (#16548)

* add cause field to disabilities array

* another flipper fix

* remove debug comment

* add comment for future engs

* tests

* nil check for input_disability

* break from loop, not break from method

* 8147 claim model (#16525)

---------

Co-authored-by: Kris Pethtel <[email protected]>
Co-authored-by: s-caso <[email protected]>
Co-authored-by: Jennica Stiehl <[email protected]>
Co-authored-by: Rebecca Tolmach <[email protected]>
Co-authored-by: Rachal Cassity <[email protected]>
Co-authored-by: Seth Darr <[email protected]>
Co-authored-by: Andrew Herzberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants