Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Upload seed data for frontend developers" #16506

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Revert "Upload seed data for frontend developers" #16506

merged 1 commit into from
Apr 25, 2024

Conversation

RachalCassity
Copy link
Member

Reverts #16502

@RachalCassity RachalCassity requested review from a team as code owners April 25, 2024 20:24
@github-actions GitHub Actions
Copy link

1 Warning
⚠️ This PR changes 285 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • modules/vye/app/models/vye/user_info.rb (+4/-1)

  • modules/vye/lib/tasks/vye.rake (+0/-58)

  • modules/vye/lib/vye/staging_data/build.rb (+0/-154)

  • modules/vye/spec/factories/vye/address_changes.rb (+0/-9)

  • modules/vye/spec/lib/vye/staging_data/build_spec.rb (+0/-44)

  • modules/vye/spec/serializers/verification_serializer_spec.rb (+0/-15)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@RachalCassity RachalCassity merged commit beb6c78 into master Apr 25, 2024
22 checks passed
@RachalCassity RachalCassity deleted the revert-16502-vye_staging_seed branch April 25, 2024 20:43
gabezurita added a commit that referenced this pull request Apr 25, 2024
@gabezurita
Merge branch 'master' into arf.80297/ARP-OGC-number-migrations
84e8fea 
* master:
  BE | Ask Va Api: Update `Correspondences::Retriever` and `Inquiries::Retriever` (#16510)
  Revert "post database updates (#16500)" (#16507)
  Revert "creates data to seed dev & staging (#16502)" (#16506)
  81092: Refactor Client Config Memoization (#16490)
gabezurita added a commit that referenced this pull request Apr 25, 2024
@gabezurita
Merge branch 'master' into arf.80297/ARP-OGC-number
069b04b 
* master:
  BE | Ask Va Api: Update `Correspondences::Retriever` and `Inquiries::Retriever` (#16510)
  Revert "post database updates (#16500)" (#16507)
  Revert "creates data to seed dev & staging (#16502)" (#16506)
  81092: Refactor Client Config Memoization (#16490)
binq added a commit that referenced this pull request May 3, 2024
@binq
Revert "Revert "creates data to seed dev & staging (#16502)" (#16506)"
601ff71 
This reverts commit beb6c78.
binq added a commit that referenced this pull request May 3, 2024
@binq
Revert "Revert "creates data to seed dev & staging (#16502)" (#16506)" (
77877ca 
#16635)

This reverts commit beb6c78.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RachalCassity