Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

81092: Refactor Client Config Memoization #16490

Merged
merged 1 commit into from
Apr 25, 2024
Merged

81092: Refactor Client Config Memoization #16490

merged 1 commit into from
Apr 25, 2024

Conversation

dickdavis
Copy link
Contributor

@dickdavis dickdavis commented Apr 24, 2024 •
edited
Loading

Summary

This PR refactors the client config lookup to memoize using key-value pairs, based on suggestions by @bosawt and @rileyanderson. This approach is preferable to removing memoization entirely, as explored in this refactor.

Related issue(s)

https://app.zenhub.com/workspaces/identity-5f5bab705a94c9001ba33734/issues/gh/department-of-veterans-affairs/va.gov-team/81092

Testing done

Regression test for signing in and logging out.

Screenshots

Not relevant.

What areas of the site does it impact?

Sign-in Service.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

None.

@dickdavis dickdavis marked this pull request as ready for review April 24, 2024 21:55
@dickdavis dickdavis requested a review from a team as a code owner April 24, 2024 21:55
@dickdavis dickdavis mentioned this pull request Apr 24, 2024
Closed
8 tasks
bosawt
bosawt approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@bosawt bosawt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed database was queried for a ClientConfig first time this function was called and not on subsequent calls

@dickdavis dickdavis merged commit e696805 into master Apr 25, 2024
22 checks passed
@dickdavis dickdavis deleted the cc-refactor branch April 25, 2024 20:34
gabezurita added a commit that referenced this pull request Apr 25, 2024
@gabezurita
Merge branch 'master' into arf.80297/ARP-OGC-number-migrations
84e8fea 
* master:
  BE | Ask Va Api: Update `Correspondences::Retriever` and `Inquiries::Retriever` (#16510)
  Revert "post database updates (#16500)" (#16507)
  Revert "creates data to seed dev & staging (#16502)" (#16506)
  81092: Refactor Client Config Memoization (#16490)
gabezurita added a commit that referenced this pull request Apr 25, 2024
@gabezurita
Merge branch 'master' into arf.80297/ARP-OGC-number
069b04b 
* master:
  BE | Ask Va Api: Update `Correspondences::Retriever` and `Inquiries::Retriever` (#16510)
  Revert "post database updates (#16500)" (#16507)
  Revert "creates data to seed dev & staging (#16502)" (#16506)
  81092: Refactor Client Config Memoization (#16490)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bosawt bosawt bosawt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dickdavis @bosawt @va-vfs-bot