add MHV MedicalRecords breakers.rb

[stephenBarrs]

Added MHV MedicalRecords to Breakers
Sort list by Alpha

Summary

• This work is behind a feature toggle (flipper): NO
• Added entry to breakers list for MedicalRecords. The goal is to make the vets_api.statsd.api_external_http_request_MedicalRecords_success and vets_api.statsd.api_external_http_request_MedicalRecords_failed metrics available in DD
  • Based on what we see with Secure Messaging and Medications, the difference is that MR is not configured in the Breakers list.
• Team: MHV Medical Records Team
• Medical Records is in Phase 0 and gets very little traffic currently

Related issue(s)

• none

Testing done

• Config Change

Screenshots

Note: Optional

What areas of the site does it impact?

• Breakers

Acceptance criteria

• entry has been added to breakers config file
• vets_api.statsd.api_external_http_request_MedicalRecords_success metric is available in DD
• vets_api.statsd.api_external_http_request_MedicalRecords_failed metric is available in DD

Requested Feedback

• Confirmation that adding the entry to Breakers is what is needed to make the success/failed metrics available in DD
• Confirmation that there is not an importance to the order of the Breakers list (because then sorting by Alpha would be bad)

[acrollet]

@stephenBarrs well after I encouraged you to alphabetize the services, it seems it broke tests! I pushed a change to revert the order that makes the tests pass locally. I'm also wondering if we could have a basic test to confirm breakers functionality like in spec/lib/sm/client/messages_spec.rb

[github-actions]

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[github-actions]

This PR has been closed because it has had no activity for 37 days