Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update org addresses using a rake task #16482

Merged
merged 11 commits into from
Apr 26, 2024
Merged

Conversation

holdenhinkle
Copy link
Contributor

@holdenhinkle holdenhinkle commented Apr 24, 2024

Resolves department-of-veterans-affairs/va.gov-team#81548

Summary

The ARM team needs to update each accredited organization's address. This rake task will handle this.

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

Fields in the veteran_organizations table that only the ARM team uses.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

Copy link

github-actions bot commented Apr 24, 2024

1 Error
🚫 This PR changes 1039 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, those exceeding
500 will not be reviewed, nor will they be allowed to merge. Please break this PR up into
smaller ones.

If you have reason to believe that this PR should be granted an exception, please see the
Submitting pull requests for approval - FAQ.

File Summary

Files

  • modules/veteran/lib/tasks/update_vso_addresses.rake (+1039/-0)

Note: We exclude files matching the following when considering PR size:

*.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@holdenhinkle holdenhinkle marked this pull request as ready for review April 24, 2024 19:05
@holdenhinkle holdenhinkle requested review from a team as code owners April 24, 2024 19:05
cosu419
cosu419 previously approved these changes Apr 24, 2024
Copy link
Contributor

@cosu419 cosu419 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Approved

@holdenhinkle holdenhinkle enabled auto-merge (squash) April 24, 2024 19:36
@holdenhinkle holdenhinkle changed the title Temporarily update org addresses in nightly UpdateNames job Update org addresses using a rake task Apr 24, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to 81548-update-org-addresses/main/main April 25, 2024 13:27 Inactive
@jvcAdHoc
Copy link
Contributor

A concern I have is around address validation. Right now the only organization addresses we'd serve to users are ones that have been validated. I don't know if all of these addresses are real and what that means on the front end with google maps links.

@va-vfs-bot va-vfs-bot temporarily deployed to 81548-update-org-addresses/main/main April 25, 2024 17:00 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 81548-update-org-addresses/main/main April 25, 2024 17:11 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 81548-update-org-addresses/main/main April 25, 2024 17:30 Inactive
@holdenhinkle
Copy link
Contributor Author

Added address validation.

To avoid LightHouse rate-limiting us, I parameterized the rake task and created constants that each contain an array of up to 20 organization/addresses to update. When running the rake task you can pass in a constant name. See the code comments for instructions.

@holdenhinkle holdenhinkle merged commit 9a50e72 into master Apr 26, 2024
21 of 22 checks passed
@holdenhinkle holdenhinkle deleted the 81548-update-org-addresses branch April 26, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update org address to match Trexler File
4 participants