-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update org addresses using a rake task #16482
Conversation
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Approved
Co-authored-by: jvcAdHoc <[email protected]>
A concern I have is around address validation. Right now the only organization addresses we'd serve to users are ones that have been validated. I don't know if all of these addresses are real and what that means on the front end with google maps links. |
Added address validation. To avoid LightHouse rate-limiting us, I parameterized the rake task and created constants that each contain an array of up to 20 organization/addresses to update. When running the rake task you can pass in a constant name. See the code comments for instructions. |
Resolves department-of-veterans-affairs/va.gov-team#81548
Summary
The ARM team needs to update each accredited organization's address. This rake task will handle this.
Related issue(s)
Testing done
Screenshots
Note: Optional
What areas of the site does it impact?
Fields in the veteran_organizations table that only the ARM team uses.
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?