Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add words_to_remove for simple forms 21-0966 #16477

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

Thrillberg
Copy link
Contributor

Summary

This PR more accurately filters out PII for form 21-0966 error messages.

Related issue(s)

https://app.zenhub.com/workspaces/vagov-product-team-forms-634853151f5c6000165942bc/issues/gh/department-of-veterans-affairs/va.gov-team/81261

Copy link
Contributor

@Japenner Japenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, great work! 👍

Copy link
Contributor

@rhasselle-oddball rhasselle-oddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, a couple of questions

Copy link
Contributor

@pennja pennja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, great work! 👍

@Thrillberg Thrillberg merged commit b2aa589 into master Apr 29, 2024
23 checks passed
@Thrillberg Thrillberg deleted the properly-filter-pii-21-0966 branch April 29, 2024 14:54
gabezurita added a commit that referenced this pull request Apr 30, 2024
* master: (33 commits)
  [DBX-74810] Add flipper with LH BI api for 4142 (#16483)
  upadte param dig call (#16570)
  98 add code to poll average days (#16471)
  8147 claim model (#16525)
  Toxic Exposure: Save TE "Add Conditions" fields for future transformation (#16548)
  Revert "ClamAV in Containers (#15965)" (#16557)
  Dangerfile updates for db migration (#16511)
  API-35829-error_handling (#16522)
  add loggers to see what dd api call is doing in staging (#16539)
  8440: fix appointments contract schema (#16528)
  ClamAV in Containers (#15965)
  Protect against calling `.any?` on a non-array (#16547)
  BE | Ask VA Api: Refactor classes and specs (#16542)
  Added '10-10EZR' to the list of freeze schemas (#16478)
  Add prefill for 10-7959c (#16448)
  Bump shrine from 3.5.0 to 3.6.0 (#16532)
  change limit on place and location. update question number (#16537)
  Add words_to_remove for simple forms 21-0966 (#16477)
  updgrade sidekiq and super_diff (#16536)
  BE | Ask Va Api:  Update `Inquiries::Creator` `Correspondences::Creator` Error Handling (#16529)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants