Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire up the backend API to frontend (Backend) #16475

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

binq
Copy link
Contributor

@binq binq commented Apr 24, 2024

https://jira.devops.va.gov/browse/VYE-338

As:

VYE Backend Developer

I need:

To updated the API to reflex and display the updated interface for addresses, and pending enrollment verification.

So that: 

Frontend developers can display on the website

Considerations:

N/A

Acceptance Criteria: 

API show new interface

Testing Considerations:

N/A

Other Considerations: 

N/A

@binq binq requested review from a team as code owners April 24, 2024 14:14
@binq binq requested a review from jsimonVA April 24, 2024 14:17
@binq binq enabled auto-merge (squash) April 24, 2024 14:18
Copy link

1 Warning
⚠️ This PR changes 259 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • db/migrate/20240424132506_remove_ssn_and_icn_from_vye_tables.vye.rb (+20/-0)

  • db/migrate/20240424132507_remove_address_details_from_vye_user_infos.vye.rb (+17/-0)

  • db/migrate/20240424132508_change_datetime_to_date.vye.rb (+16/-0)

  • db/migrate/20240424132509_update_verifications.vye.rb (+15/-0)

  • db/migrate/20240424132510_create_vye_bdn_clones.vye.rb (+15/-0)

  • db/migrate/20240424132511_add_to_vye_user_infos.vye.rb (+14/-0)

  • db/migrate/20240424132512_remove_from_vye_pending_document.vye.rb (+8/-0)

  • db/schema.rb (+31/-25)

  • modules/vye/db/migrate/20240303145700_remove_ssn_and_icn_from_vye_tables.rb (+19/-0)

  • modules/vye/db/migrate/20240305034315_remove_address_details_from_vye_user_infos.rb (+16/-0)

  • modules/vye/db/migrate/20240415205522_change_datetime_to_date.rb (+15/-0)

  • modules/vye/db/migrate/20240415220728_update_verifications.rb (+14/-0)

  • modules/vye/db/migrate/20240422033815_create_vye_bdn_clones.rb (+14/-0)

  • modules/vye/db/migrate/20240422043836_add_to_vye_user_infos.rb (+13/-0)

  • modules/vye/db/migrate/20240422051918_remove_from_vye_pending_document.rb (+7/-0)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@binq binq added the Please Review This PR had changes requested by reviewer AND IS NOW COMPLETE label Apr 24, 2024
@binq binq merged commit 8a4a934 into master Apr 25, 2024
23 checks passed
@binq binq deleted the vye-338-wire-to-frontend--2-db-up branch April 25, 2024 13:29
RachalCassity added a commit that referenced this pull request Apr 25, 2024
gabezurita added a commit that referenced this pull request Apr 25, 2024
* master:
  creates data to seed dev & staging (#16502)
  post database updates (#16500)
  Added auth-only feature flipper for 10-10EZR (#16496)
  update vsoreloader to correctly upsert organization data (#16470)
  database updates (#16475)
  Bump super_diff from 0.11.0 to 0.12.0 (#16495)
gabezurita added a commit that referenced this pull request Apr 25, 2024
…-OGC-number

* arf.80297/ARP-OGC-number-migrations:
  creates data to seed dev & staging (#16502)
  post database updates (#16500)
  Added auth-only feature flipper for 10-10EZR (#16496)
  update vsoreloader to correctly upsert organization data (#16470)
  database updates (#16475)
  Bump super_diff from 0.11.0 to 0.12.0 (#16495)
  arf-80297 add ARP verified_representative migration
RachalCassity added a commit that referenced this pull request Apr 25, 2024
* Revert "database updates (#16475)"

This reverts commit 8a4a934.

* Revertig migrations
@RachalCassity RachalCassity self-assigned this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Please Review This PR had changes requested by reviewer AND IS NOW COMPLETE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants