Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api 35595 registration numbers #16469

Closed
wants to merge 5 commits into from

Conversation

mchristiansonVA
Copy link
Contributor

Summary

  • This work is behind a feature toggle (flipper): NO
  • Updates documentation examples to use a value of "999999999999" for registrationNumber attribute of 2122 and 2122a submissions, as well as corresponding validate calls.
  • Updates tests where appropriate to accommodate value change.

Related issue(s)

-API-35595

Testing done

  • New code is covered by unit tests
  • Confirmed locally that documentation examples for affected endpoints reflect the update value for registrationNumber

Screenshots

Screenshot 2024-04-23 at 3 48 13 PM

What areas of the site does it impact?

526 documentation.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@mchristiansonVA mchristiansonVA added the claimsApi modules/claims_api label Apr 23, 2024
@mchristiansonVA mchristiansonVA self-assigned this Apr 23, 2024
@mchristiansonVA mchristiansonVA requested review from a team as code owners April 23, 2024 19:50
@va-vfs-bot va-vfs-bot temporarily deployed to API-35595-registration-numbers/main/main April 23, 2024 20:29 Inactive
@mchristiansonVA mchristiansonVA force-pushed the API-35595-registration-numbers branch from 8e6e430 to e128f8d Compare April 24, 2024 13:48
@mchristiansonVA mchristiansonVA requested review from a team as code owners April 24, 2024 13:48
@va-vfs-bot va-vfs-bot temporarily deployed to API-35595-registration-numbers/main/main April 24, 2024 13:52 Inactive
@mchristiansonVA mchristiansonVA deleted the API-35595-registration-numbers branch April 24, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimsApi modules/claims_api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants