-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toxic Exposure: Add basic toxicExposure node to pre-submission JSON #16450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
dbex/80718-TE-transform-2/main/main
April 22, 2024 23:40
Inactive
va-vfs-bot
temporarily deployed
to
dbex/80718-TE-transform-2/main/main
April 23, 2024 21:49
Inactive
va-vfs-bot
temporarily deployed
to
dbex/80718-TE-transform-2/main/main
April 23, 2024 22:57
Inactive
va-vfs-bot
temporarily deployed
to
dbex/80718-TE-transform-2/main/main
April 24, 2024 16:04
Inactive
va-vfs-bot
temporarily deployed
to
dbex/80718-TE-transform-2/main/main
April 24, 2024 19:01
Inactive
freeheeling
reviewed
Apr 24, 2024
spec/support/disability_compensation_form/submissions/with_everything.json
Show resolved
Hide resolved
spec/support/disability_compensation_form/submissions/with_everything.json
Outdated
Show resolved
Hide resolved
aurora-a-k-a-lightning
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the top-level
toxicExposure
JSON node to the pre-submission JSON. At this stage, this is merely a pass-through. Later, it will be transformed by the Form526ToLighthouseTransformer into the Lighthouse request formatSummary
Related issue(s)
Testing done
Pre-submission form json minus the new toxicExposure node would NOT be added to the submission form json
With the disability_526_toxic_exposure flag ON, submit a 526ez with TE questions answered, confirm that the TE nodes make it to the saved submission record
Screenshots
Note: Optional
What areas of the site does it impact?
(Describe what parts of the site are impacted andifcode touched other areas)
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?