LocalBGS cleanup

[nihil2501]

Move miscellaneous operations out so that:

• it is easier to look at base-level functionality without all of these various operation implementations intermingled
• these various operation implementations can eventually be organized according to the standards we've used for other operations

[github-actions]

1 Error

🚫

This PR changes 1083 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, those exceeding 500 will not be reviewed, nor will they be allowed to merge. Please break this PR up into smaller ones. If you have reason to believe that this PR should be granted an exception, please see the Submitting pull requests for approval - FAQ. File Summary Files config/features.yml (+4/-0) modules/claims_api/README.md (+2/-2) modules/claims_api/app/clients/claims_api/bgs_client.rb (+117/-0) modules/claims_api/app/clients/claims_api/bgs_client/service_action/definition.rb (+28/-0) modules/claims_api/app/clients/claims_api/bgs_client/service_action/external_id.rb (+15/-0) modules/claims_api/app/clients/claims_api/bgs_client/service_action/request.rb (+212/-0) modules/claims_api/app/clients/claims_api/bgs_client/service_action/request/envelope.rb (+75/-0) modules/claims_api/lib/bgs_service/local_bgs.rb (+57/-0) modules/claims_api/lib/bgs_service/local_bgs_refactored.rb (+107/-0) modules/claims_api/lib/bgs_service/local_bgs_refactored/error_handler.rb (+75/-0) modules/claims_api/lib/bgs_service/local_bgs_refactored/miscellaneous.rb (+204/-0) modules/claims_api/spec/lib/claims_api/bgs/veteran_representative_service/create_veteran_representative_request_spec.rb (+2/-2) modules/claims_api/spec/lib/claims_api/bgs/veteran_representative_service/read_all_veteran_representatives_spec.rb (+2/-2) modules/claims_api/spec/lib/claims_api/bgs/veteran_representative_service/veteran_representative_service_spec.rb (+0/-1) modules/claims_api/spec/lib/claims_api/local_bgs_refactored_spec.rb (+123/-0) modules/claims_api/spec/lib/claims_api/local_bgs_spec.rb (+8/-0) modules/claims_api/spec/lib/claims_api/manage_representative_service/read_poa_request_spec.rb (+2/-2) modules/claims_api/spec/lib/claims_api/manage_representative_service/update_poa_request_spec.rb (+2/-2) modules/claims_api/spec/lib/claims_api/vnp_atchms_service_spec.rb (+2/-2) modules/claims_api/spec/lib/claims_api/vnp_person_service_spec.rb (+2/-2) modules/claims_api/spec/lib/claims_api/vnp_ptcpnt_addrs_service_spec.rb (+2/-2) modules/claims_api/spec/requests/v2/power_of_attorney_requests/index/rswag_spec.rb (+2/-2) modules/claims_api/spec/support/{bgs_client_helpers.rb => bgs_client_spec_helpers.rb} (+10/-11) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger