Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datadog version tag configuration #16383

Merged
merged 6 commits into from
Apr 19, 2024
+5 −2
Merged

Add datadog version tag configuration #16383

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
73ae737
Add datadog version config
acrollet Apr 17, 2024
3ded666
Update datadog version tag in manifest on deploy
acrollet Apr 17, 2024
30dace8
Merge branch 'k8s' into dd-version-vets-api
acrollet Apr 17, 2024
5069b84
Remove datadog initializer change from k8s branch
acrollet Apr 18, 2024
b3b887a
Update values editing for consistency
acrollet Apr 18, 2024
b4ba315
Merge branch 'k8s' into dd-version-vets-api
acrollet Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/deploy-template.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ jobs:
fetch-depth: 1
path: vsp-infra-application-manifests

- name: Update vets-api image name in Manifest repo for parent helm
- name: Update vets-api image and version name in Manifest repo for parent helm
env:
ECR_REGISTRY: ${{ steps.login-ecr.outputs.registry }}
ECR_REPOSITORY: dsva/${{inputs.ecr_repository}}
Expand All @@ -80,7 +80,10 @@ jobs:
envs=( ${{ needs.prepare-values.outputs.environments }} )
for env in ${envs[*]};
do
yq e -i '(.vets-api.image.tag) |= "${{ github.sha }}"' $env/values.yaml
yq e -i '(."vets-api".image.tag) |= "${{ github.sha }}"' $env/values.yaml
yq e -i '(."vets-api".web.envSecrets[] | select(.name=="DD_VERSION").value) |= "${{ github.sha }}"' $env/values.yaml
yq e -i '(."vets-api".web.dbMigrate.envSecrets[] | select(.name=="DD_VERSION").value) |= "${{ github.sha }}"' $env/values.yaml
yq e -i '(."vets-api".worker.envSecrets[] | select(.name=="DD_VERSION").value) |= "${{ github.sha }}"' $env/values.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for having "vets-api" in quotes on these three lines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was necessary because of the hyphen when I was testing locally, it would probably be good to add it to the existing line as well. Maybe it's due to a yq version difference?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possibly. I bet both versions work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The jq manual says that keys with special chars should be quoted - I went ahead and added it to the first line for consistency.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok sounds good!

done
git diff

Expand Down
Loading