veteran_representatives Migration

[stevenjcumming]

Summary

• Remove dob_ciphertext and ssn_ciphertext columns from veteran_representatives table. These encrypted fields were indirectly causing an issue with the KMS key rotation job.
• Remove encrypted_kms_key column from veteran_representatives table
• Remove precision: nil from schema. Rails treats nil as default value: 6. So precision: nil is no longer necessary as of Rails 7.1

Related issue(s)

• Remove DOB and SSN from veteran_representatives #16369
• Remove DOB and SSN from veteran_representatives table va.gov-team#80875
• This morning the KmsKeyRotation::RotateKeyJob sidekiq job fa... va.gov-team#80806

Testing done

• test suite passes

Acceptance Criteria

• dob_ciphertext, ssn_ciphertext, encrypted_kms_key are removed from the schema

[github-actions]

1 Warning

⚠️

This PR changes 257 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files db/migrate/20240417130647_remove_dob_and_ssn_from_veteran_representatives.rb (+9/-0) db/schema.rb (+122/-126) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[jvcAdHoc]

Looks like this made its way back in the file with the same pr that added the precison: nil.

We don't need it and it was originally removed in this pr

[gabezurita]

LGTM! Seems like we also removed code using ssn and dob in another PR

[rmtolmach]

Thanks for running this down, Steven!