Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 20-10207 mapping and date stamp bug #16376

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Fix 20-10207 mapping and date stamp bug #16376

merged 1 commit into from
Apr 17, 2024

Conversation

Thrillberg
Copy link
Contributor

Summary

This small PR does two things:

  1. Fix another data mapping bug with 20-10207 (the Other1[0] is on page 4 not 3)
  2. When stamping the auth text, we want it to stamp on every page. Therefore we should not pass a page argument.
    The JSON update is incidental. It just makes the data make more sense.

@Thrillberg Thrillberg requested review from a team as code owners April 17, 2024 12:39
pennja
pennja approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@pennja pennja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@Thrillberg Thrillberg merged commit 88ec761 into master Apr 17, 2024
20 checks passed
@Thrillberg Thrillberg deleted the 20-10207-pdf-mapping-fixes branch April 17, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pennja pennja pennja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Thrillberg @pennja @va-vfs-bot