Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to request a token from STS #16372

Merged
merged 8 commits into from
Apr 17, 2024
Merged

Add method to request a token from STS #16372

merged 8 commits into from
Apr 17, 2024

Conversation

kjduensing
Copy link
Contributor

This adds a method and call to request an STS token from the sign-in service.

Github issue: department-of-veterans-affairs/va.gov-team#80255

@va-vfs-bot va-vfs-bot temporarily deployed to btsss-sts-token/main/main April 17, 2024 02:04 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to btsss-sts-token/main/main April 17, 2024 02:21 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to btsss-sts-token/main/main April 17, 2024 14:41 Inactive
athifw
athifw previously approved these changes Apr 17, 2024
Copy link
Contributor

@athifw athifw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - suggestion: change def request_btsss_token(veis_token, vagov_token) to def request_btsss_token(veis_token, sts_token)

@kjduensing kjduensing marked this pull request as ready for review April 17, 2024 17:12
@kjduensing kjduensing requested review from a team as code owners April 17, 2024 17:12
@kjduensing kjduensing merged commit 3a3ec61 into master Apr 17, 2024
20 checks passed
@kjduensing kjduensing deleted the btsss-sts-token branch April 17, 2024 20:08
rmtolmach added a commit that referenced this pull request Apr 17, 2024
* Refactor uploads spec, simple forms (#16380)

* Refactor uploads spec, simple forms

* rubocop

* BTSSS-77372 Add mocked responses for BTSSS  (#16231)

* Revert to original token URL in service

* Add authorized ping mock, too

* Handle Bearer Token parsing failures gracefully

* Clean up services config

* Revert some accidental deletions

* Final bit of cleanup

* Switch to correct file path

* Move authorize method to a before_action

* Update mockdata paths

* Fix some linting errors

* Add direct deposit email notification template (#16357)

* Add template_type method to VANotifyEmailJob

* Update direct deposit email job to accept a default parameter of nil for the direct deposit type.

* Add method to request a token from STS (#16372)

* Add method to request a token from STS

* fix rubocop

* Fix tests

* Remove debugging line

* change parameter to reflect actual value

* Merge conflict fix

* remove diff file from merge conflict

* [80904] Creating a terms of use application check that occurs during secondary authentications with custom (#16371)

---------

Co-authored-by: Eric Tillberg <[email protected]>
Co-authored-by: Dan Hinze <[email protected]>
Co-authored-by: Tom Harrison <[email protected]>
Co-authored-by: Kevin Duensing <[email protected]>
Co-authored-by: Trevor Bosaw <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants