Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed feature toggle profile_show_proof_of_veteran_status #16368

Merged
merged 1 commit into from
May 2, 2024
Merged

Removed feature toggle profile_show_proof_of_veteran_status #16368

merged 1 commit into from
May 2, 2024

Conversation

stevelong00
Copy link
Contributor

@stevelong00 stevelong00 commented Apr 16, 2024 •
edited
Loading

Summary

  • This work is behind a feature toggle (flipper): NO
  • Summary: removed feature toggle profile_show_proof_of_veteran_status
  • Team IIR, we are the new owners of this component

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Prior to this change, the component was behind a feature toggle. Now it is not.
  • The feature toggle is no longer available in the Flipper UI. The component is always available to users with an honorable discharge and at least one period of service..

Screenshots

None

What areas of the site does it impact?

This only impacts one page.

Acceptance criteria

  • I updated unit tests for this feature.
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

None

@va-vfs-bot va-vfs-bot temporarily deployed to 533-remove-proof-of-veteran-status-feature-toggle/533-remove-proof-of-veteran-status-feature-toggle/main April 16, 2024 21:09 Inactive
khenson-oddball
khenson-oddball approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@khenson-oddball khenson-oddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stevelong00 stevelong00 marked this pull request as ready for review April 30, 2024 16:36
@stevelong00 stevelong00 requested review from a team as code owners April 30, 2024 16:36
@RachalCassity
Copy link
Member

LGTM

@RachalCassity RachalCassity self-assigned this May 2, 2024
@platform-support-slack-integration platform-support-slack-integration bot mentioned this pull request May 2, 2024
Closed
@stevelong00 stevelong00 merged commit 16f061b into master May 2, 2024
20 checks passed
@stevelong00 stevelong00 deleted the 533-remove-proof-of-veteran-status-feature-toggle branch May 2, 2024 20:40
stevelong00 added a commit that referenced this pull request May 2, 2024
@stevelong00
Revert "Removed feature toggle profile_show_proof_of_veteran_status (#…
5e7e755 
…16368)"

This reverts commit 16f061b.
@stevelong00 stevelong00 mentioned this pull request May 2, 2024
Merged
stevelong00 added a commit that referenced this pull request May 3, 2024
@stevelong00
Revert "Removed feature toggle profile_show_proof_of_veteran_status (#…
5ec9452 
…16368)" (#16617)

This reverts commit 16f061b.
gabezurita added a commit that referenced this pull request May 3, 2024
@gabezurita
Merge branch 'master' into arf.80297/ARP-OGC-number
b3def1c 
* master:
  Dash/oren/api 34439/local bgs refactor (#16526)
  Bump rubocop-rspec from 2.29.1 to 2.29.2 (#16622)
  Revert "Removed feature toggle profile_show_proof_of_veteran_status (#16368)" (#16617)
  Simple Forms: Pull pdf upload out into a service (#16615)
  80367 add prefill 10 7959f 1 (#16499)
  arf-80297 add ARP verified_representative migration (#16494)
@stevelong00 stevelong00 restored the 533-remove-proof-of-veteran-status-feature-toggle branch May 3, 2024 16:39
@github-actions github-actions bot deleted the 533-remove-proof-of-veteran-status-feature-toggle branch October 22, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khenson-oddball khenson-oddball khenson-oddball approved these changes

@RachalCassity RachalCassity RachalCassity approved these changes

Assignees

@RachalCassity RachalCassity

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stevelong00 @RachalCassity @khenson-oddball @va-vfs-bot