-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vets-json-schema #16362
Update vets-json-schema #16362
Conversation
da0ca53
to
526477f
Compare
526477f
to
a2a36fc
Compare
@@ -51,14 +51,14 @@ | |||
[{ 'title' => 'Validation error', | |||
'detail' => "The property '#/application/veteran/militaryStatus' of " \ | |||
'type null did not match the following type: string in ' \ | |||
'schema 47e1937d-acd7-50a1-9cc6-fab567bd62cb', | |||
'schema 72d7bc55-042d-5bfd-8001-2b7c815c8e06', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The schema id for form 40-10007 was updated by 15bda2f, due to the update to the common state enum for Canadian provinces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
branch: master | ||
specs: | ||
vets_json_schema (22.0.3) | ||
vets_json_schema (22.1.1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because vets-website has gotten updated to 22.1.0
since then (https://github.com/department-of-veterans-affairs/vets-website/blob/0ee8639c13d4da5c4520e70c2e79bb75236407c5/yarn.lock#L20599), so it seemed best to keep them in sync
Summary
Related issue(s)
Testing done
Acceptance criteria