Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vets-json-schema #16362

Merged
merged 6 commits into from
Apr 18, 2024
Merged

Update vets-json-schema #16362

merged 6 commits into from
Apr 18, 2024

Conversation

TaiWilkin
Copy link
Contributor

@TaiWilkin TaiWilkin commented Apr 16, 2024

Summary

Related issue(s)

Testing done

  • Submitted form and confirmed updated addresses were accepted.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@TaiWilkin TaiWilkin force-pushed the pensions-80659-schemaupdate branch from da0ca53 to 526477f Compare April 16, 2024 16:49
@va-vfs-bot va-vfs-bot temporarily deployed to pensions-80659-schemaupdate/main/main April 16, 2024 17:07 Inactive
@TaiWilkin TaiWilkin force-pushed the pensions-80659-schemaupdate branch from 526477f to a2a36fc Compare April 16, 2024 19:20
@va-vfs-bot va-vfs-bot temporarily deployed to pensions-80659-schemaupdate/main/main April 16, 2024 19:27 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to pensions-80659-schemaupdate/main/main April 16, 2024 20:18 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to pensions-80659-schemaupdate/main/main April 16, 2024 20:45 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to pensions-80659-schemaupdate/main/main April 17, 2024 12:25 Inactive
@@ -51,14 +51,14 @@
[{ 'title' => 'Validation error',
'detail' => "The property '#/application/veteran/militaryStatus' of " \
'type null did not match the following type: string in ' \
'schema 47e1937d-acd7-50a1-9cc6-fab567bd62cb',
'schema 72d7bc55-042d-5bfd-8001-2b7c815c8e06',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The schema id for form 40-10007 was updated by 15bda2f, due to the update to the common state enum for Canadian provinces.

Copy link
Contributor

@jperk51 jperk51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

branch: master
specs:
vets_json_schema (22.0.3)
vets_json_schema (22.1.1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because vets-website has gotten updated to 22.1.0 since then (https://github.com/department-of-veterans-affairs/vets-website/blob/0ee8639c13d4da5c4520e70c2e79bb75236407c5/yarn.lock#L20599), so it seemed best to keep them in sync

@TaiWilkin TaiWilkin requested a review from rmtolmach April 17, 2024 17:42
@TaiWilkin TaiWilkin enabled auto-merge (squash) April 18, 2024 12:02
@TaiWilkin TaiWilkin merged commit 9e9cbcb into master Apr 18, 2024
20 checks passed
@TaiWilkin TaiWilkin deleted the pensions-80659-schemaupdate branch April 18, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants