-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
80792 remove redis client refactor feature flag #16353
Conversation
@randomsync tag me once you have a teammate's review and then I'll take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@rmtolmach ... approved by my team member. please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks right to me. Nice work finishing up the feature!
@randomsync You'll also need to manually remove check_in_experience_travel_claim_redis_client_refactor
from dev, staging, sandbox and prod. See step 3 here: https://depo-platform-documentation.scrollhelp.site/developer-docs/feature-toggles-guide#Featuretogglesguide-Removingold/unusedfeaturetoggles
Please @ me if you or someone on your team doesn't have access to argo in an environment and I can do it for you :)
✅ flippers removed in all environments. |
Summary
This PR removes the travel claim redis client refactor flag. The code has been running in production successfully and this flag is no longer necessary.
Related issue(s)
Testing done
Acceptance criteria