Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

80792 remove redis client refactor feature flag #16353

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

randomsync
Copy link
Member

Summary

This PR removes the travel claim redis client refactor flag. The code has been running in production successfully and this flag is no longer necessary.

Related issue(s)

Testing done

  • rspecs

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).

@randomsync randomsync requested review from a team as code owners April 16, 2024 00:44
@va-vfs-bot va-vfs-bot temporarily deployed to 80792_remove_redis_client_refactor_ff/main/main April 16, 2024 00:45 Inactive
@randomsync randomsync enabled auto-merge (squash) April 16, 2024 00:45
@rmtolmach
Copy link
Contributor

@randomsync tag me once you have a teammate's review and then I'll take a look.

Copy link
Contributor

@kanchanasuriya kanchanasuriya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@va-vfs-bot va-vfs-bot temporarily deployed to 80792_remove_redis_client_refactor_ff/main/main April 16, 2024 21:35 Inactive
@randomsync
Copy link
Member Author

@randomsync tag me once you have a teammate's review and then I'll take a look.

@rmtolmach ... approved by my team member. please review

Copy link
Contributor

@rmtolmach rmtolmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right to me. Nice work finishing up the feature!

@randomsync You'll also need to manually remove check_in_experience_travel_claim_redis_client_refactor from dev, staging, sandbox and prod. See step 3 here: https://depo-platform-documentation.scrollhelp.site/developer-docs/feature-toggles-guide#Featuretogglesguide-Removingold/unusedfeaturetoggles

Please @ me if you or someone on your team doesn't have access to argo in an environment and I can do it for you :)

@randomsync randomsync merged commit c04424a into master Apr 17, 2024
20 checks passed
@randomsync randomsync deleted the 80792_remove_redis_client_refactor_ff branch April 17, 2024 14:05
@rmtolmach
Copy link
Contributor

✅ flippers removed in all environments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants