Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ndbex/69209 ch36 to benefits intake #16351

Merged
merged 30 commits into from
Apr 16, 2024

Conversation

micahaspyr
Copy link
Contributor

Summary

  • This work is behind a feature toggle (flipper): YES
  • This moves all Ch 36 submissions to the new Benefits Intake API endpoints for submission
  • The feature update now routes to Benefits Intake API and is behind a flipper to control which endpoint is accessed
    -Non disabilities exp team Umbrella owns this
  • Success is that all claims being pushed to Benefits Intake API successfully upload

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Old claims were being sent to the Central Mail API which has now been deprecated
  • Submit an Education and Career Counseling Claims (CH36) form and verify that it has shown up in the sidekiq job queue
  • Tests were written for the different flipper states
    • We will be rolling this out first with 10% of traffic going to the endpoint

What areas of the site does it impact?

This affects all Ch36 claims

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected

…ts-api into ndbex/69209-ch36-to-benefits-intake
…ts-api into ndbex/69209-ch36-to-benefits-intake
…ts-api into ndbex/69209-ch36-to-benefits-intake
…ts-api into ndbex/69209-ch36-to-benefits-intake
@va-vsp-bot
Copy link
Collaborator

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: app/models/saved_claim/education_career_counseling_claim.rb

@va-vfs-bot va-vfs-bot temporarily deployed to ndbex/69209-ch36-to-benefits-intake/main/main April 15, 2024 22:43 Inactive
@micahaspyr micahaspyr added the education-career-counseling-benefits Label used for Pull Requests that impact Educational and career counseling claims (CH36, 25-8832) label Apr 15, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to ndbex/69209-ch36-to-benefits-intake/main/main April 15, 2024 22:56 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to ndbex/69209-ch36-to-benefits-intake/main/main April 15, 2024 23:01 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to ndbex/69209-ch36-to-benefits-intake/main/main April 15, 2024 23:09 Inactive
app/sidekiq/lighthouse/submit_career_counseling_job.rb Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
@micahaspyr micahaspyr marked this pull request as ready for review April 16, 2024 17:30
@micahaspyr micahaspyr requested review from a team as code owners April 16, 2024 17:30
@micahaspyr micahaspyr merged commit 839a958 into master Apr 16, 2024
20 checks passed
@micahaspyr micahaspyr deleted the ndbex/69209-ch36-to-benefits-intake branch April 16, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
education-career-counseling-benefits Label used for Pull Requests that impact Educational and career counseling claims (CH36, 25-8832)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants