78475 adjust fsr calculators

[kjsuarez]

Summary

Adjusting business logic on backend to mirror existing logic currently on front end.

Related issue(s)

80577

Testing done

Specs added

What areas of the site does it impact?

Currently endpoints are not in use. Eventually these endpoints will effect the Financial Status Report.

Acceptance criteria

The FSR calculator endpoints described in this PR should return the exact same values as their FE counterparts.

[github-actions]

1 Warning

⚠️

This PR changes 304 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files modules/debts_api/app/controllers/debts_api/v0/financial_status_reports_calculations_controller.rb (+78/-69) modules/debts_api/lib/debts_api/v0/fsr_form_transform/asset_calculator.rb (+8/-8) modules/debts_api/lib/debts_api/v0/fsr_form_transform/enhanced_expense_calculator.rb (+3/-3) modules/debts_api/lib/debts_api/v0/fsr_form_transform/expense_calculator.rb (+3/-2) modules/debts_api/lib/debts_api/v0/fsr_form_transform/income_calculator.rb (+32/-34) modules/debts_api/lib/debts_api/v0/fsr_form_transform/old_expense_calculator.rb (+1/-1) modules/debts_api/spec/lib/debt_api/v0/fsr_form_transform/asset_calculator_spec.rb (+1/-1) modules/debts_api/spec/lib/debt_api/v0/fsr_form_transform/expense_calculator_spec.rb (+1/-1) modules/debts_api/spec/lib/debt_api/v0/fsr_form_transform/income_calculator_spec.rb (+1/-1) modules/debts_api/spec/request/debts_api/v0/financial_status_reports_calculations_controller_spec.rb (+56/-0) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[OptionSelect]

LGTM! 🚀

[rmtolmach]

You might want someone on the vsa-debt-resolution team to take a look as well, but LGTM.