Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KmsKeyRotation::BatchInitiatorJob nil encrypted_kms_key error #16336

Merged
merged 1 commit into from
Apr 15, 2024
Merged

KmsKeyRotation::BatchInitiatorJob nil encrypted_kms_key error #16336

merged 1 commit into from
Apr 15, 2024

Conversation

stevenjcumming
Copy link
Contributor

Summary

  • KmsKeyRotation::BatchInitiatorJob#gids_for_model doesn't include records with nil key
  • Add .or(model.where(encrypted_kms_key: nil)) to include in key rotation job

Related issue(s)

Testing done

  • Manual testing

Acceptance criteria

  • gids_for_model returns records with encrypted_kms_key = nil

@stevenjcumming stevenjcumming requested review from a team as code owners April 15, 2024 16:13
@stevenjcumming stevenjcumming self-assigned this Apr 15, 2024
rmtolmach
rmtolmach approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@rmtolmach rmtolmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you specifically wanted Eric's review, but this LGTM.

@stevenjcumming stevenjcumming merged commit 0c474b1 into master Apr 15, 2024
20 checks passed
@stevenjcumming stevenjcumming deleted the sjc-kms-key-rotation-nil-key branch April 15, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmtolmach rmtolmach rmtolmach approved these changes

@ericboehs ericboehs Awaiting requested review from ericboehs

Assignees

@stevenjcumming stevenjcumming

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevenjcumming @rmtolmach @va-vfs-bot