Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update vets_json_schema to v22.1.1 #16335

Closed
wants to merge 1 commit into from

Conversation

danlim715
Copy link
Contributor

Summary

  • This work is behind a feature toggle (flipper): NO
  • Update vets-json-schema version to 22.1.1
  • Pension benefits team to own this change.

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@danlim715 danlim715 added the pension-benefits Used for PRs that impact Pensions label Apr 15, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to update-vets-json-schema-v22.1.1/main/main April 15, 2024 15:57 Inactive
@danlim715 danlim715 force-pushed the update-vets-json-schema-v22.1.1 branch from 5e71c72 to a3086c5 Compare April 15, 2024 16:56
@va-vfs-bot va-vfs-bot temporarily deployed to update-vets-json-schema-v22.1.1/main/main April 15, 2024 17:00 Inactive
@danlim715 danlim715 force-pushed the update-vets-json-schema-v22.1.1 branch from a3086c5 to d49d867 Compare April 15, 2024 17:26
@va-vfs-bot va-vfs-bot temporarily deployed to update-vets-json-schema-v22.1.1/main/main April 15, 2024 17:49 Inactive
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 15, 2024
Copy link

This PR has been closed because it has had no activity for 37 days

@github-actions github-actions bot closed this May 22, 2024
@github-actions github-actions bot deleted the update-vets-json-schema-v22.1.1 branch May 22, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pension-benefits Used for PRs that impact Pensions Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants