Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighthouse Benefits Intake Configuration #16332

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

wayne-weibel
Copy link
Contributor

@wayne-weibel wayne-weibel commented Apr 15, 2024

Summary

add configuration for centralized lighthouse benefits intake service

Related issue(s)

department-of-veterans-affairs/va.gov-team#75579
#16333
#16324

Testing done

  • New code is covered by unit tests
  • it is not needed to be behind a flipper, does not affect current applications
  • tested locally via console
  • add local config - request sandbox api_key here
lighthouse:
  benefits_intake:
    host: https://sandbox-api.va.gov
    path: /services/vba_documents
    version: v1
    use_mocks: false
    api_key: API_KEY

What areas of the site does it impact?

None

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

@va-vfs-bot va-vfs-bot temporarily deployed to feature/lighthouse-benefits-intake-config/main/main April 15, 2024 14:29 Inactive
Copy link
Contributor

@mjknight50 mjknight50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the comments baked in. LGTM

@wayne-weibel wayne-weibel marked this pull request as ready for review April 15, 2024 17:58
@wayne-weibel wayne-weibel requested review from a team as code owners April 15, 2024 17:58
path: /services/vba_documents
version: v1
use_mocks: false
api_key: ~
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you be adding this information to the manifest repo (and parameter store)? https://depo-platform-documentation.scrollhelp.site/developer-docs/vets-api-on-eks#VetsAPIonEKS-Secretvalues

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmtolmach Yes absolutely, wanted to get the library up for review before tackling the deployment (ie. needed to know what the configuration would be first)

@wayne-weibel wayne-weibel requested a review from rmtolmach April 16, 2024 14:43
@wayne-weibel wayne-weibel merged commit 16986fc into master Apr 16, 2024
20 checks passed
@wayne-weibel wayne-weibel deleted the feature/lighthouse-benefits-intake-config branch April 16, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benefits-intake Lighthouse Benefits Intake API pension-benefits Used for PRs that impact Pensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants