Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

97 average number of days db work only #16331

Merged
merged 9 commits into from
Apr 15, 2024

Conversation

jbackfieldVA
Copy link
Contributor

@jbackfieldVA jbackfieldVA commented Apr 15, 2024

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

  • This work is behind a feature toggle (flipper): No
  • This is adding a public endpoint to return the average number of days to claim completion which will be stored in the database.
  • VES

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Endpoint didn't exist, database table didn't exist
  • Access the endpoint (with or without authentication) and receive a value.

What areas of the site does it impact?

No other code was touched in this except the schema file to include the new table creation. This will be used for chatbot to display the average number of days to claim completion.

Acceptance criteria

  • I created the database table in a rails migration
  • I updated the schema.rb file to include the new table
  • Added unprotected endpoint to query the latest value
  • We handle if there are no records in the database
  • SPEC written and passes.
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

Requested Feedback

We are going to be creating a github action to insert records into the new table. This will only run ONCE per week so we are looking at a very small footprint of data in the database. There is a desire to keep the historical records in the database however, there is no discussion of data retention at the moment as the current schedule would mean that we would expect to run for 20 years before we even had 1000 records. If we need an index on the created_at in order to speed up the DB request, we can make that change.

@jbackfieldVA jbackfieldVA requested review from a team as code owners April 15, 2024 13:45
@va-vfs-bot va-vfs-bot temporarily deployed to 97-average_number_of_days_db/main/main April 15, 2024 13:46 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 97-average_number_of_days_db/main/main April 15, 2024 13:59 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 97-average_number_of_days_db/main/main April 15, 2024 14:28 Inactive
@jbackfieldVA jbackfieldVA merged commit 209b1d7 into master Apr 15, 2024
20 checks passed
@jbackfieldVA jbackfieldVA deleted the 97-average_number_of_days_db branch April 15, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants