Removing unused download_pdf functionality from health_care_application controller

[bosawt]

Summary

• This PR removes the unused route, download_pdf from the health_care_application controller. I looked at data dog, and see no evidence this route was ever used (except my own testing today, and in Oct 2023): https://vagov.ddog-gov.com/logs?query=health_care_applications%2Fdownload_pdf%20&cols=host%2Cservice&fromUser=true&index=%2A&messageDisplay=inline&refresh_mode=paused&storage=online_archives&stream_sort=desc&viz=stream&from_ts=1672560000000&to_ts=1712956020000&live=false. Also, this route is not references in the frontend, so it seems to be dead code.

[github-actions]

1 Warning

⚠️

This PR changes 454 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files app/controllers/v0/health_care_applications_controller.rb (+1/-16) config/routes.rb (+0/-1) lib/pdf_fill/filler.rb (+0/-2) lib/pdf_fill/forms/maps/input_map_1010_ez.rb (+0/-111) lib/pdf_fill/forms/maps/key_map_1010_ez.rb (+0/-113) lib/pdf_fill/forms/va1010ez.rb (+0/-193) spec/controllers/v0/health_care_applications_controller_spec.rb (+0/-17) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[Mitch-A6]

👍 Looks solid! Love to see unused code like this cut, thanks much!

[rmtolmach]

Thanks, Trevor!