Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

71999 scour payload #16308

Merged
merged 9 commits into from
Apr 16, 2024
Merged

71999 scour payload #16308

merged 9 commits into from
Apr 16, 2024

Conversation

lee-delarm6
Copy link
Contributor

Summary

  • Removing https://va.gov from system in the VAOS appointments payload

Related issue(s)

Testing done

  • Rspec updated and written
  • Peer review

Note

  • This will need to be refactored in after other current updates are finished and deployed

@lee-delarm6 lee-delarm6 requested review from a team as code owners April 11, 2024 20:30
@va-vfs-bot va-vfs-bot temporarily deployed to 71999_scour_payload/main/main April 11, 2024 20:48 Inactive
db/schema.rb Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these schema changes intentional?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lee-delarm6 you will have to revert the changes to schema, not sure how they made it in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted changes, it's back to whatever is current in main now

Revert schema
@va-vfs-bot va-vfs-bot temporarily deployed to 71999_scour_payload/main/main April 15, 2024 13:31 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 71999_scour_payload/main/main April 15, 2024 13:37 Inactive
Match updated schema
@lee-delarm6 lee-delarm6 requested a review from rmtolmach April 15, 2024 13:38
@va-vfs-bot va-vfs-bot temporarily deployed to 71999_scour_payload/main/main April 15, 2024 13:42 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 71999_scour_payload/main/main April 16, 2024 12:44 Inactive
Copy link
Contributor

@kanchanasuriya kanchanasuriya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lee-delarm6 lee-delarm6 merged commit 4f0b8fb into master Apr 16, 2024
20 checks passed
@lee-delarm6 lee-delarm6 deleted the 71999_scour_payload branch April 16, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants