-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove deprecated 'branch' option #16301
Conversation
Generated by 🚫 Danger |
Error: A file (or its parent directories) was deleted but its reference still exists in CODEOWNERS. Please update the .github/CODEOWNERS file and delete the entry for the Offending file: |
Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: |
@rmtolmach This commits the image tags to the manifest repo's main branch. The main branch should not be removed. |
@RachalCassity I believe it commits to the default branch ( |
The default branch would be k8s. Let me look into this more. |
But it's pushing into the manifest repo. This is definitely a low-priority item, it's just something I saw while on support. So if it feels too risky, we can just close it. |
The new_branch allows customizing the branch name. In this workflow, the default branch would be k8s. We are sending this to another repo and the k8s branch does not exist. We can add main as the new_branch |
I want to reiterate that nothing is broken here. This PR would just remove the warning: I don't know if we do need to add
So currently what it's running is |
Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: |
Error: A file (or its parent directories) was deleted but its reference still exists in CODEOWNERS. Please update the .github/CODEOWNERS file and delete the entry for the Offending file: |
Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: |
Error: A file (or its parent directories) was deleted but its reference still exists in CODEOWNERS. Please update the .github/CODEOWNERS file and delete the entry for the Offending file: |
Summary
This updates an action in the k8s branch to remove a deprecated option. It was removed here: EndBug/add-and-commit@6fdb34e and we get warnings about it (here, for example. Note: it's not making anything fail)
Trying
new_branch
. Not having a branch option was pushing this to all active branches, which we don't need.https://dsva.slack.com/archives/C0460N83Y9G/p1713967398724749
What areas of the site does it impact?
k8s branch github action that pushes tag to manifest repo.
Testing
I'll watch CI after merge.