Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Data Column From Personal Information Log #16300

Merged
merged 11 commits into from
Apr 16, 2024

Conversation

stevenjcumming
Copy link
Contributor

@stevenjcumming stevenjcumming commented Apr 11, 2024

Summary

Related issue(s)

Acceptance criteria

  • data column is removed
  • PersonalInformationLog "data" is still accessible through the data_ciphertext column

Copy link

github-actions bot commented Apr 11, 2024

1 Error
🚫

Modified files in db/migrate or db/schema.rb changes should be the only files checked into this PR.

File Summary

DB File(s)

  • db/migrate/20240411152758_drop_data_in_personal_information_log.rb

  • db/schema.rb

    App File(s)

    • .github/CODEOWNERS
  • app/models/personal_information_log.rb

  • spec/lib/common/client/middleware/logging_spec.rb

  • spec/models/personal_information_log_spec.rb

Database migrations do not run automatically with vets-api deployments. Application code must always be
backwards compatible with the DB, both before and after migrations have been run. For more info:

Generated by 🚫 Danger

@stevenjcumming stevenjcumming marked this pull request as ready for review April 11, 2024 17:37
@stevenjcumming stevenjcumming requested review from a team as code owners April 11, 2024 17:37
@va-vfs-bot va-vfs-bot temporarily deployed to sjc-pil-encryption-p2/main/main April 11, 2024 17:43 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to sjc-pil-encryption-p2/main/main April 12, 2024 11:14 Inactive
@va-vsp-bot
Copy link
Collaborator

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: app/models/personal_information_log.rb

@va-vfs-bot va-vfs-bot temporarily deployed to sjc-pil-encryption-p2/main/main April 16, 2024 13:37 Inactive
@va-vsp-bot
Copy link
Collaborator

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: spec/lib/common/client/middleware/logging_spec.rb

@va-vfs-bot va-vfs-bot temporarily deployed to sjc-pil-encryption-p2/main/main April 16, 2024 13:42 Inactive
@va-vsp-bot
Copy link
Collaborator

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: spec/models/personal_information_log_spec.rb

@va-vfs-bot va-vfs-bot temporarily deployed to sjc-pil-encryption-p2/main/main April 16, 2024 13:48 Inactive
@stevenjcumming stevenjcumming self-assigned this Apr 16, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to sjc-pil-encryption-p2/main/main April 16, 2024 13:54 Inactive
@stevenjcumming stevenjcumming merged commit 74f39cf into master Apr 16, 2024
19 of 20 checks passed
@stevenjcumming stevenjcumming deleted the sjc-pil-encryption-p2 branch April 16, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants