Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dash/oren/api 34439 poa requests index response spec #16273

Closed

Conversation

nihil2501
Copy link
Contributor

To get a nice web view of proposed schema and a corresponding example, download, extract, and open this in your browser: v2-power-of-attorney-requests-response-draft.zip

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

  • This work is behind a feature toggle (flipper): YES/NO
  • (Summarize the changes that have been made to the platform)
  • (If bug, how to reproduce)
  • (What is the solution, why is this the solution?)
  • (Which team do you work for, does your team own the maintenance of this component?)
  • (If introducing a flipper, what is the success criteria being targeted?)

Related issue(s)

  • Link to ticket created in va.gov-team repo OR screenshot of Jira ticket if your team uses Jira
  • Link to previous change of the code/bug (if applicable)
  • Link to epic if not included in ticket

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

Verified by running the claims_api test suite while having this check configured to raise if a cassette was used from outside claims_api:
```ruby
VCR.configure do |config|
  config.before_playback do |interaction, cassette|
    if cassette.name[/^claims_api\//].nil?
      raise "still needs migrating: #{cassette.name}"
    end
  end
end
```
use filter sensitive data for bgs url rather than erb templating
@va-vfs-bot va-vfs-bot temporarily deployed to dash/oren/API-34439-poa-requests-index-endpoint/main/main April 10, 2024 05:59 Inactive
@nihil2501 nihil2501 force-pushed the dash/oren/API-34439-poa-requests-index-endpoint branch from 39438cf to 7a9e58a Compare April 10, 2024 06:01
@nihil2501 nihil2501 added the claimsApi modules/claims_api label Apr 10, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to dash/oren/API-34439-poa-requests-index-endpoint/main/main April 10, 2024 06:11 Inactive
@nihil2501 nihil2501 force-pushed the dash/oren/API-34439-poa-requests-index-endpoint branch from 7a9e58a to a83d2ca Compare April 10, 2024 06:17
@va-vfs-bot va-vfs-bot temporarily deployed to dash/oren/API-34439-poa-requests-index-endpoint/main/main April 10, 2024 06:18 Inactive
@nihil2501 nihil2501 force-pushed the dash/oren/API-34439-poa-requests-index-endpoint branch from a83d2ca to 58cf45f Compare April 10, 2024 06:20
@va-vfs-bot va-vfs-bot temporarily deployed to dash/oren/API-34439-poa-requests-index-endpoint/main/main April 10, 2024 06:24 Inactive
@nihil2501 nihil2501 force-pushed the dash/oren/API-34439-poa-requests-index-endpoint branch from 58cf45f to 04a62ba Compare April 10, 2024 15:04
Base automatically changed from dash/oren/claims-api-bgs-cassette-cleanup to master April 10, 2024 15:10
@va-vfs-bot va-vfs-bot temporarily deployed to dash/oren/API-34439-poa-requests-index-endpoint/main/main April 10, 2024 15:22 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dash/oren/API-34439-poa-requests-index-endpoint/main/main April 10, 2024 15:45 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dash/oren/API-34439-poa-requests-index-endpoint/main/main April 10, 2024 17:44 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dash/oren/API-34439-poa-requests-index-endpoint/main/main April 11, 2024 05:52 Inactive
@nihil2501 nihil2501 force-pushed the dash/oren/API-34439-poa-requests-index-endpoint branch from c6751e6 to 435d835 Compare April 12, 2024 16:47
@va-vfs-bot va-vfs-bot temporarily deployed to dash/oren/API-34439-poa-requests-index-endpoint/main/main April 12, 2024 17:05 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dash/oren/API-34439-poa-requests-index-endpoint/main/main April 12, 2024 17:23 Inactive
@nihil2501 nihil2501 force-pushed the dash/oren/API-34439-poa-requests-index-endpoint branch from 54874dd to c6e6b6b Compare April 12, 2024 21:47
@va-vfs-bot va-vfs-bot temporarily deployed to dash/oren/API-34439-poa-requests-index-endpoint/main/main April 12, 2024 21:52 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimsApi modules/claims_api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants