-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dash/oren/api 34439 poa requests index response spec #16273
Closed
nihil2501
wants to merge
13
commits into
master
from
dash/oren/API-34439-poa-requests-index-endpoint
Closed
Dash/oren/api 34439 poa requests index response spec #16273
nihil2501
wants to merge
13
commits into
master
from
dash/oren/API-34439-poa-requests-index-endpoint
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verified by running the claims_api test suite while having this check configured to raise if a cassette was used from outside claims_api: ```ruby VCR.configure do |config| config.before_playback do |interaction, cassette| if cassette.name[/^claims_api\//].nil? raise "still needs migrating: #{cassette.name}" end end end ```
use filter sensitive data for bgs url rather than erb templating
va-vfs-bot
temporarily deployed
to
dash/oren/API-34439-poa-requests-index-endpoint/main/main
April 10, 2024 05:59
Inactive
nihil2501
force-pushed
the
dash/oren/API-34439-poa-requests-index-endpoint
branch
from
April 10, 2024 06:01
39438cf
to
7a9e58a
Compare
va-vfs-bot
temporarily deployed
to
dash/oren/API-34439-poa-requests-index-endpoint/main/main
April 10, 2024 06:11
Inactive
nihil2501
force-pushed
the
dash/oren/API-34439-poa-requests-index-endpoint
branch
from
April 10, 2024 06:17
7a9e58a
to
a83d2ca
Compare
va-vfs-bot
temporarily deployed
to
dash/oren/API-34439-poa-requests-index-endpoint/main/main
April 10, 2024 06:18
Inactive
nihil2501
force-pushed
the
dash/oren/API-34439-poa-requests-index-endpoint
branch
from
April 10, 2024 06:20
a83d2ca
to
58cf45f
Compare
va-vfs-bot
temporarily deployed
to
dash/oren/API-34439-poa-requests-index-endpoint/main/main
April 10, 2024 06:24
Inactive
nihil2501
force-pushed
the
dash/oren/API-34439-poa-requests-index-endpoint
branch
from
April 10, 2024 15:04
58cf45f
to
04a62ba
Compare
Base automatically changed from
dash/oren/claims-api-bgs-cassette-cleanup
to
master
April 10, 2024 15:10
va-vfs-bot
temporarily deployed
to
dash/oren/API-34439-poa-requests-index-endpoint/main/main
April 10, 2024 15:22
Inactive
va-vfs-bot
temporarily deployed
to
dash/oren/API-34439-poa-requests-index-endpoint/main/main
April 10, 2024 15:45
Inactive
va-vfs-bot
temporarily deployed
to
dash/oren/API-34439-poa-requests-index-endpoint/main/main
April 10, 2024 17:44
Inactive
va-vfs-bot
temporarily deployed
to
dash/oren/API-34439-poa-requests-index-endpoint/main/main
April 11, 2024 05:52
Inactive
nihil2501
force-pushed
the
dash/oren/API-34439-poa-requests-index-endpoint
branch
from
April 12, 2024 16:47
c6751e6
to
435d835
Compare
va-vfs-bot
temporarily deployed
to
dash/oren/API-34439-poa-requests-index-endpoint/main/main
April 12, 2024 17:05
Inactive
va-vfs-bot
temporarily deployed
to
dash/oren/API-34439-poa-requests-index-endpoint/main/main
April 12, 2024 17:23
Inactive
nihil2501
force-pushed
the
dash/oren/API-34439-poa-requests-index-endpoint
branch
from
April 12, 2024 21:47
54874dd
to
c6e6b6b
Compare
va-vfs-bot
temporarily deployed
to
dash/oren/API-34439-poa-requests-index-endpoint/main/main
April 12, 2024 21:52
Inactive
nihil2501
force-pushed
the
dash/oren/API-34439-poa-requests-index-endpoint
branch
from
April 12, 2024 21:59
c6e6b6b
to
20d5bff
Compare
va-vfs-bot
temporarily deployed
to
dash/oren/API-34439-poa-requests-index-endpoint/main/main
April 12, 2024 22:00
Inactive
nihil2501
deleted the
dash/oren/API-34439-poa-requests-index-endpoint
branch
September 27, 2024 00:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get a nice web view of proposed schema and a corresponding example, download, extract, and open this in your browser: v2-power-of-attorney-requests-response-draft.zip
Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.
Summary
Related issue(s)
Testing done
Screenshots
Note: Optional
What areas of the site does it impact?
(Describe what parts of the site are impacted andifcode touched other areas)
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?