Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8189 appointments index schema corrections #16245

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

kpethtel
Copy link
Contributor

@kpethtel kpethtel commented Apr 8, 2024

Summary

Makes corrections to expected schema and prevents running the checks on empty data.

Related issue(s)

department-of-veterans-affairs/va-mobile-app#8189

Testing done

  • specs.

Screenshots

Note: Optional

What areas of the site does it impact?

Could impact appointments index but shouldn't impact anything.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

@kpethtel kpethtel marked this pull request as ready for review April 8, 2024 19:48
@kpethtel kpethtel requested review from a team as code owners April 8, 2024 19:48
@@ -538,6 +538,12 @@ def update_appointment_vaos(appt_id, status)
params = VAOS::V2::UpdateAppointmentForm.new(status:).params
perform(:put, url_path, params, headers)
end

def validate_response_schema(response, contract_name)
return unless response.success? && response.body[:data].present?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this guard because only 2 of the first 25 runs had actual data in them. 17 were just empty and 6 had upstream failures (so the data was also empty).

@kpethtel kpethtel merged commit cf9f579 into master Apr 8, 2024
20 checks passed
@kpethtel kpethtel deleted the 8189-appointments-index-schema-corrections branch April 8, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants