Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[78699] adds service_levels and credential_service_providers attributes to ClientConfig #16238

Merged
merged 5 commits into from
Apr 9, 2024

Conversation

bramleyjl
Copy link
Contributor

@bramleyjl bramleyjl commented Apr 8, 2024

Summary

  • Adds service_levels and credential_service_providers attributes to SignIn::ClientConfig. These attributes will be validated against requested CSP and ACR during /authorize to allow SiS clients to prevent certain CSPs or ACRs from use.
  • credential_service_providers default values: [ 'logingov', 'idme', 'dslogon', 'mhv']
  • service_levels default values: [ 'ial1', 'ial2', 'loa1', 'loa3', 'min']

Related issue(s)

Testing done

  • Confirmed new attributes were present with default on existing & newly created ClientConfigs.

@bramleyjl bramleyjl self-assigned this Apr 8, 2024
@bramleyjl bramleyjl added identity identity-backend Identity team backend label labels Apr 8, 2024
@bramleyjl bramleyjl marked this pull request as ready for review April 8, 2024 15:29
@bramleyjl bramleyjl requested review from a team as code owners April 8, 2024 15:29
@va-vfs-bot va-vfs-bot temporarily deployed to 78699_client_config_csp_block/main/main April 8, 2024 15:32 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 78699_client_config_csp_block/main/main April 8, 2024 16:39 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 78699_client_config_csp_block/main/main April 8, 2024 18:56 Inactive
Copy link
Contributor

@bosawt bosawt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small naming preference changes

@bramleyjl bramleyjl force-pushed the 78699_client_config_csp_block branch from 4938bd9 to ca3c858 Compare April 8, 2024 21:55
@bramleyjl bramleyjl requested a review from bosawt April 8, 2024 21:56
@va-vfs-bot va-vfs-bot temporarily deployed to 78699_client_config_csp_block/main/main April 8, 2024 22:03 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 78699_client_config_csp_block/main/main April 9, 2024 15:12 Inactive
@bramleyjl bramleyjl force-pushed the 78699_client_config_csp_block branch from 98b07fa to 8cb9952 Compare April 9, 2024 15:14
@va-vfs-bot va-vfs-bot temporarily deployed to 78699_client_config_csp_block/main/main April 9, 2024 15:18 Inactive
@bramleyjl bramleyjl changed the title [78699] adds csps and acrs attributes to ClientConfig [78699] adds service_levels and credential_service_providers attributes to ClientConfig Apr 9, 2024
@bramleyjl bramleyjl merged commit b399e67 into master Apr 9, 2024
20 checks passed
@bramleyjl bramleyjl deleted the 78699_client_config_csp_block branch April 9, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
identity identity-backend Identity team backend label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants