-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[78699] adds service_levels
and credential_service_providers
attributes to ClientConfig
#16238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
78699_client_config_csp_block/main/main
April 8, 2024 15:32
Inactive
va-vfs-bot
temporarily deployed
to
78699_client_config_csp_block/main/main
April 8, 2024 16:39
Inactive
7 tasks
va-vfs-bot
temporarily deployed
to
78699_client_config_csp_block/main/main
April 8, 2024 18:56
Inactive
bosawt
requested changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just small naming preference changes
bramleyjl
force-pushed
the
78699_client_config_csp_block
branch
from
April 8, 2024 21:55
4938bd9
to
ca3c858
Compare
va-vfs-bot
temporarily deployed
to
78699_client_config_csp_block/main/main
April 8, 2024 22:03
Inactive
va-vfs-bot
temporarily deployed
to
78699_client_config_csp_block/main/main
April 9, 2024 15:12
Inactive
bramleyjl
force-pushed
the
78699_client_config_csp_block
branch
from
April 9, 2024 15:14
98b07fa
to
8cb9952
Compare
va-vfs-bot
temporarily deployed
to
78699_client_config_csp_block/main/main
April 9, 2024 15:18
Inactive
bramleyjl
changed the title
[78699] adds csps and acrs attributes to ClientConfig
[78699] adds Apr 9, 2024
service_levels
and credential_service_providers
attributes to ClientConfig
bosawt
approved these changes
Apr 9, 2024
ericboehs
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
service_levels
andcredential_service_providers
attributes to SignIn::ClientConfig. These attributes will be validated against requested CSP and ACR during/authorize
to allow SiS clients to prevent certain CSPs or ACRs from use.credential_service_providers
default values: [ 'logingov', 'idme', 'dslogon', 'mhv']service_levels
default values: [ 'ial1', 'ial2', 'loa1', 'loa3', 'min']Related issue(s)
/authenticate
csp type & acr #16241Testing done