Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Api 34936 ptcpnt addrs create #16188

Merged
merged 22 commits into from
Apr 15, 2024
Merged

Api 34936 ptcpnt addrs create #16188

merged 22 commits into from
Apr 15, 2024

Conversation

mchristiansonVA
Copy link
Contributor

@mchristiansonVA mchristiansonVA commented Apr 3, 2024 •
edited
Loading

Summary

  • Adds the VnpPtcpntAddrsService with associated test and VCR cassette.

Related issue(s)

API-34936

Testing done

  • New code is covered by unit tests
  • Tested via rspec test and VCR cassette creation.

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@va-vfs-bot va-vfs-bot temporarily deployed to API-34936-ptcpnt-addrs-create/main/main April 3, 2024 14:38 Inactive
@mchristiansonVA mchristiansonVA added the claimsApi modules/claims_api label Apr 3, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to API-34936-ptcpnt-addrs-create/main/main April 4, 2024 14:29 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-34936-ptcpnt-addrs-create/main/main April 4, 2024 19:20 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-34936-ptcpnt-addrs-create/main/main April 4, 2024 22:02 Inactive
@mchristiansonVA mchristiansonVA marked this pull request as ready for review April 4, 2024 22:22
@mchristiansonVA mchristiansonVA requested review from a team as code owners April 4, 2024 22:22
@stevenjcumming
Copy link
Contributor

@mchristiansonVA please ask a teammate for a review then I'll review it

ericboehs
ericboehs previously approved these changes Apr 9, 2024
View reviewed changes
@va-vfs-bot va-vfs-bot temporarily deployed to API-34936-ptcpnt-addrs-create/main/main April 11, 2024 14:12 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-34936-ptcpnt-addrs-create/main/main April 11, 2024 14:59 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-34936-ptcpnt-addrs-create/main/main April 15, 2024 16:54 Inactive
@nihil2501 nihil2501 force-pushed the API-34936-ptcpnt-addrs-create branch from df93bc4 to 7c70c31 Compare April 15, 2024 17:07
nihil2501
nihil2501 previously approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@nihil2501 nihil2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nihil2501 nihil2501 requested a review from FonzMP April 15, 2024 17:14
@va-vfs-bot va-vfs-bot temporarily deployed to API-34936-ptcpnt-addrs-create/main/main April 15, 2024 17:36 Inactive
@nihil2501 nihil2501 self-requested a review April 15, 2024 18:52
nihil2501
nihil2501 approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@nihil2501 nihil2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mchristiansonVA mchristiansonVA merged commit bbfcc31 into master Apr 15, 2024
20 checks passed
@mchristiansonVA mchristiansonVA deleted the API-34936-ptcpnt-addrs-create branch April 15, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nihil2501 nihil2501 nihil2501 approved these changes

@ericboehs ericboehs ericboehs left review comments

@FonzMP FonzMP Awaiting requested review from FonzMP

Assignees
No one assigned
Labels
claimsApi modules/claims_api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mchristiansonVA @stevenjcumming @ericboehs @nihil2501 @FonzMP @va-vfs-bot