Setup dsva-prt-build-deploy team as code owners for deployment files #16098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/CODEOWNERS
Outdated
| @@ -1928,3 +1928,7 @@ spec/requests/va_profile/contacts_request_spec.rb @department-of-veterans-affair | |||
| /.github/workflows/build-and-publish.yaml @department-of-veterans-affairs/backend-review-group | |||
| modules/accredited_representative_portal @department-of-veterans-affairs/benefits-accredited-rep-facing @department-of-veterans-affairs/backend-review-group | |||
| README.md @department-of-veterans-affairs/backend-review-group | |||
| /Dockerfile-k8s @department-of-veterans-affairs/dsva-prt-build-deploy | |||
| /.github/workflows/build-and-publish.yml @department-of-veterans-affairs/dsva-prt-build-deploy | |||
There was a problem hiding this comment.
You will also need to add backend review group to these files
added 2 commits
March 27, 2024 13:32
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
This PR has been closed because it has had no activity for 37 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request establishes explicit code ownership for key deployment configuration files within the
vets-apirepository, ensuring that changes to critical files are reviewed by the newly formeddsva-prt-build-deployteam. This team, composed of DevOps engineers (Patrick B., Ben A., and myself Keenan S.), will oversee the Dockerfile configurations, Kubernetes deployment manifests, and CI/CD workflow definitions.Changes Made:
dsva-prt-build-deployteam as code owners for theDockerfile-k8s, ensuring oversight on containerization specifications.dsva-prt-build-deployteam to the.github/workflows/build-and-publish.ymlfile to manage the CI/CD pipeline configurations.dsva-prt-build-deployteam as owners of thehelmCharts/directory to supervise changes in Kubernetes deployment charts.