Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-34933-proc-form-create #16092

Merged
merged 11 commits into from
Mar 28, 2024
Merged

API-34933-proc-form-create #16092

merged 11 commits into from
Mar 28, 2024

Conversation

mchristiansonVA
Copy link
Contributor

@mchristiansonVA mchristiansonVA commented Mar 26, 2024

Summary

  • This work is behind a feature toggle (flipper): NO
  • Adds vnp_proc_form_service and test with new cassette

Related issue(s)

API-34933

Testing done

  • Added rspec test & cassette

What areas of the site does it impact?

modules/claims_api/lib/bgs_service/vnp_proc_form_service.rb
modules/claims_api/spec/lib/claims_api/vnp_proc_form_service_spec.rb
spec/support/vcr_cassettes/bgs/vnp_proc_service_v2/vnp_proc_form_service.yml

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@mchristiansonVA mchristiansonVA added the claimsApi modules/claims_api label Mar 26, 2024
@mchristiansonVA mchristiansonVA self-assigned this Mar 26, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to API-34933-proc-form-create/main/main March 26, 2024 18:37 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-34933-proc-form-create/main/main March 26, 2024 19:24 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-34933-proc-form-create/main/main March 27, 2024 14:21 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-34933-proc-form-create/main/main March 27, 2024 14:27 Inactive
@mchristiansonVA mchristiansonVA marked this pull request as ready for review March 27, 2024 14:31
@mchristiansonVA mchristiansonVA requested review from a team as code owners March 27, 2024 14:31
private

def convert_nil_values(options)
arg_strg = ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mchristiansonVA I am thinking about moving this method into local_bgs since we are both using it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, was just about to ask you that! Let me know if you want me to do that or just follow your lead...

@va-vfs-bot va-vfs-bot temporarily deployed to API-34933-proc-form-create/main/main March 27, 2024 18:36 Inactive
stiehlrod
stiehlrod previously approved these changes Mar 27, 2024
stiehlrod
stiehlrod previously approved these changes Mar 27, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to API-34933-proc-form-create/main/main March 27, 2024 19:35 Inactive
@mchristiansonVA mchristiansonVA merged commit 3666035 into master Mar 28, 2024
20 checks passed
@mchristiansonVA mchristiansonVA deleted the API-34933-proc-form-create branch March 28, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimsApi modules/claims_api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants