Ndbex 71275 pdf stamping

[evansmith]

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

• This work is behind a feature toggle (flipper): NO
• I altered the submit saved claim job to check for the 21P-530 form. If that is the claim type, it will run an additional step stamping the PDF in the upper right hand box on the first page where a Veteran enters information.
• (If bug, how to reproduce)
• Currently this is special-cased because the other PDFs don't make use of this functionality. In the future it could potentially be modularized.
• VA Benefits and Claims
• (If introducing a flipper, what is the success criteria being targeted?)

Related issue(s)

• Link to ticket created in va.gov-team repo OR screenshot of Jira ticket if your team uses Jira

Testing done

• New code is covered by unit tests
• Previously no pdf covered by the submit saved claim job would have a stamp in the upper right hand corner.
• Proceed through the creation of a 21P-530V2 form. In the submission that is sent to Central Mail the PDF should contain the stamp. Alternatively, calling the specific method in a Rails console with the 21P-530V2 claim will generate a pdf in tmp for review. Unit tests cover the behavior for 21P-530V2 and the previous version of submit saved claim job to make sure other pdfs were not affected.

Screenshots

Note: Optional

What areas of the site does it impact?

submit_saved_claim_job, most particularly when a new Burial is submitted (after the release of V2).

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog or Grafana (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?