Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Job Cancellation Code from VBADocuments::UploadProcessor #16087

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

kristen-brown
Copy link
Contributor

@kristen-brown kristen-brown commented Mar 26, 2024

Summary

A production issue began on March 25, 2024 where Benefits Intake API submissions were not being processed out of "uploaded" status. The issue is ongoing, and we suspect that it is caused by the job cancellation code, which is not in regular use. The job is currently succeeding quickly, but short-circuiting any of the real processing code, so it is not behaving as expected. No code changes were made this past week, so we suspect it may be related to the Redis upgrade. The job cancellation code calls Redis under the hood.

My team (Lighthouse Team Banana Peels) maintains the vba_documents module.

Related issue(s)

None, as this was discovered as a production issue.

Testing done

Ensured that all Benefits Intake endpoints still return their expected response after removing the job cancellation code, and that records can be processed locally.

Screenshots

None

What areas of the site does it impact?

This PR impacts the vba_documents module only.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation) – N/A
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature – N/A

Requested Feedback

No specific feedback requested for this PR.

@kristen-brown kristen-brown added the banana-peels Lighthouse Banana Peels Team label Mar 26, 2024
@kristen-brown kristen-brown requested a review from a team as a code owner March 26, 2024 14:57
@kristen-brown kristen-brown merged commit 7f0a6ce into master Mar 26, 2024
18 checks passed
@kristen-brown kristen-brown deleted the vba-documents-production-bug-stuck-in-uploaded branch March 26, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
banana-peels Lighthouse Banana Peels Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants