Remove Job Cancellation Code from VBADocuments::UploadProcessor
#16087
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A production issue began on March 25, 2024 where Benefits Intake API submissions were not being processed out of "uploaded" status. The issue is ongoing, and we suspect that it is caused by the job cancellation code, which is not in regular use. The job is currently succeeding quickly, but short-circuiting any of the real processing code, so it is not behaving as expected. No code changes were made this past week, so we suspect it may be related to the Redis upgrade. The job cancellation code calls Redis under the hood.
My team (Lighthouse Team Banana Peels) maintains the
vba_documents
module.Related issue(s)
None, as this was discovered as a production issue.
Testing done
Ensured that all Benefits Intake endpoints still return their expected response after removing the job cancellation code, and that records can be processed locally.
Screenshots
None
What areas of the site does it impact?
This PR impacts the
vba_documents
module only.Acceptance criteria
Requested Feedback
No specific feedback requested for this PR.