-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API-34934-request-vpn-participant-create #16081
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the test url from dev to staging in test.yml. Adds vnp_ptcpnt_service and test, with cassette - WIP. Adds method in local_bgs to check for requreed params once we know what those are.
va-vfs-bot
temporarily deployed
to
API-34934-request-vpn-participant-create/main/main
March 26, 2024 19:37
Inactive
va-vfs-bot
temporarily deployed
to
API-34934-request-vpn-participant-create/main/main
March 26, 2024 21:43
Inactive
…it so it can be used in another service.
va-vfs-bot
temporarily deployed
to
API-34934-request-vpn-participant-create/main/main
March 27, 2024 17:49
Inactive
va-vfs-bot
temporarily deployed
to
API-34934-request-vpn-participant-create/main/main
March 27, 2024 19:10
Inactive
mchristiansonVA
previously approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and observed a successful call to vnpPtcpntCreate in /VnpPtcpntWebServiceBean/VnpPtcpntService. Looks good to me!
mchristiansonVA
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks more good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Testing done
What areas of the site does it impact?
Acceptance criteria