Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-34934-request-vpn-participant-create #16081

Merged
merged 13 commits into from
Mar 28, 2024

Conversation

stiehlrod
Copy link
Contributor

@stiehlrod stiehlrod commented Mar 25, 2024

Summary

  • Adds to the get_fault_info method in the soap_error_handler.
  • Adds vnp_ptcpnt_service and test, with cassette

Related issue(s)

Testing done

  • Added corresponding test & cassette

What areas of the site does it impact?

modified:   modules/claims_api/lib/bgs_service/local_bgs.rb
modified:   modules/claims_api/lib/bgs_service/vnp_ptcpnt_service.rb
modified:   spec/support/vcr_cassettes/bgs/vnp_proc_service_v2/vnp_ptcpnt_service.yml

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

…the test url from dev to staging in test.yml. Adds vnp_ptcpnt_service and test, with cassette - WIP. Adds method in local_bgs to check for requreed params once we know what those are.
@stiehlrod stiehlrod marked this pull request as ready for review March 26, 2024 19:36
@stiehlrod stiehlrod requested review from a team as code owners March 26, 2024 19:36
@va-vfs-bot va-vfs-bot temporarily deployed to API-34934-request-vpn-participant-create/main/main March 26, 2024 19:37 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-34934-request-vpn-participant-create/main/main March 26, 2024 21:43 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-34934-request-vpn-participant-create/main/main March 27, 2024 17:49 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-34934-request-vpn-participant-create/main/main March 27, 2024 19:10 Inactive
Copy link
Contributor

@mchristiansonVA mchristiansonVA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and observed a successful call to vnpPtcpntCreate in /VnpPtcpntWebServiceBean/VnpPtcpntService. Looks good to me!

Copy link
Contributor

@mchristiansonVA mchristiansonVA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks more good to me!

@stiehlrod stiehlrod merged commit 20bae71 into master Mar 28, 2024
20 checks passed
@stiehlrod stiehlrod deleted the API-34934-request-vpn-participant-create branch March 28, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimsApi modules/claims_api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants