Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bdn import #16079

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Bdn import #16079

merged 2 commits into from
Mar 25, 2024

Conversation

binq
Copy link
Contributor

@binq binq commented Mar 25, 2024

https://jira.devops.va.gov/browse/VYE-237

As:

VYE Backend Developer

I need:

To create a parser BDN file

So that: 

Data can be ingest to VYE database

Considerations:

No considerations

Acceptance Criteria: 

The parser BDN file is able to ingest data to VYE database

Other Considerations: 

No other considerations

Copy link

1 Warning
⚠️ This PR changes 230 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • modules/vye/app/models/vye/address_change.rb (+15/-9)

  • modules/vye/app/models/vye/award.rb (+7/-6)

  • modules/vye/app/models/vye/user_info.rb (+19/-8)

  • modules/vye/app/models/vye/user_profile.rb (+9/-1)

  • modules/vye/config/bdn_line_extraction_config.yaml (+61/-0)

  • modules/vye/lib/vye/batch_transfer/ingress_files.rb (+15/-1)

  • modules/vye/lib/vye/batch_transfer/ingress_files/bdn_line_extraction.rb (+68/-0)

  • modules/vye/lib/vye/engine.rb (+1/-0)

  • modules/vye/spec/factories/vye/address_changes.rb (+1/-0)

  • modules/vye/spec/lib/vye/batch_transfer/ingress_files_spec.rb (+8/-1)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@binq binq marked this pull request as ready for review March 25, 2024 20:54
@binq binq requested review from a team as code owners March 25, 2024 20:54
@binq binq enabled auto-merge (squash) March 25, 2024 20:54
@binq binq merged commit 74bce21 into master Mar 25, 2024
18 checks passed
@binq binq deleted the bdn_import branch March 25, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants