Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test cert #16077

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Update test cert #16077

merged 1 commit into from
Mar 26, 2024

Conversation

acovrig
Copy link
Contributor

@acovrig acovrig commented Mar 25, 2024

Summary

  • Update a test cert used in specs.
    This fixes an issue for people that are on openssl v3.2.1.

Related issue(s)

  • no ticket created

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

What areas of the site does it impact?

Nothing public, just when running specs, specifically anything that uses fake_vbms

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

Is this reverse-compatible with older versions of OpenSSL? I presume it is given the GH Action tests pass.

@acovrig acovrig added the claimsApi modules/claims_api label Mar 25, 2024
@acovrig acovrig self-assigned this Mar 25, 2024
@acovrig acovrig requested a review from a team as a code owner March 25, 2024 20:32
@stiehlrod stiehlrod self-requested a review March 25, 2024 20:47
@acovrig acovrig merged commit 885d782 into master Mar 26, 2024
20 checks passed
@acovrig acovrig deleted the update-test-cert branch March 26, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimsApi modules/claims_api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants