Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBMS-61276: Self-Service: Pre-Need Pre-Integration: CMP UUID Text size Increase #16074

Conversation

adam-antonioli
Copy link
Contributor

@adam-antonioli adam-antonioli commented Mar 25, 2024

Jira Link: MBMS-61276

Summary

As a developer I need to ensure the UUID is easily processable by the VBA/IBM Automation bot so that all data makes it successfully to EOAS

Testing done

  • Local testing

Screenshots

Screenshot 2024-03-22 at 14 50 54 Screenshot 2024-03-22 at 14 50 59 Screenshot 2024-03-22 at 14 51 04 Screenshot 2024-03-22 at 14 51 12

What areas of the site does it impact?

Pre-need form 40-10007

Acceptance criteria

Screenshot 2024-03-26 at 14 49 39
  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

ksantiagoBAH
ksantiagoBAH previously approved these changes Mar 25, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to MBMS-61276-Self-Service-Pre-Need-Pre-Integration-CMP-UUID-Text-size-Increase/main/main March 25, 2024 19:41 Inactive
ConnorJeff
ConnorJeff previously approved these changes Mar 25, 2024
@adam-antonioli adam-antonioli dismissed stale reviews from ConnorJeff and ksantiagoBAH via df2a78f March 26, 2024 13:33
@va-vfs-bot va-vfs-bot temporarily deployed to MBMS-61276-Self-Service-Pre-Need-Pre-Integration-CMP-UUID-Text-size-Increase/main/main March 26, 2024 13:34 Inactive
@adam-antonioli adam-antonioli marked this pull request as ready for review March 26, 2024 18:44
@adam-antonioli adam-antonioli requested review from a team as code owners March 26, 2024 18:44
@adam-antonioli adam-antonioli enabled auto-merge (squash) March 26, 2024 18:45
@adam-antonioli adam-antonioli changed the title MBMS-61276 change UUID size and position on pre need form 40-10007 pdf MBMS-61276: Self-Service: Pre-Need Pre-Integration: CMP UUID Text size Increase Mar 26, 2024
@adam-antonioli adam-antonioli merged commit 2b7d0e7 into master Mar 26, 2024
20 checks passed
@adam-antonioli adam-antonioli deleted the MBMS-61276-Self-Service-Pre-Need-Pre-Integration-CMP-UUID-Text-size-Increase branch March 26, 2024 19:01
agravell047 added a commit that referenced this pull request Mar 28, 2024
* udpated swagger docs/test

* fixed linter and updated types

* added new yml for rxRfRecord object

* Codespaces native (#15935)

* Add hybrid setup config

* Various fixes

* Improve startup

* Don't try to bring app up in start

* Add mockdata config

* Improve startup

* More QoL improvements

* Improve startup

* Add ruby lsp ext after start

* Create log dir on start

* Improvements

* Change setup to facilitate ruby lsp extension installation

* Remove manual extension installation

* Fix startup script

* More work on deps

* Set user id when starting deps

* More adjustments to startup scripts

* simplify docker deps setup

* Wait for the api to be ready before exiting the startup script

* More QoL improvements

* Change setup order

* Add output for permissions set

* Adjust permissions approach

* One more adjustment

* Belt & suspenders

* More perms adjustment

* Simplify startup

* Add native setup

* Change ruby setup to enable

* Add hardware requirements

* Add test DB config

* Add docs

* Update postgres version

* Update redis version

* Fix foreman output

* Use different redis package

* Minor debug output

* Don't bother with starting the app

* Improve test database config

* Update doc

* Remove host requirements

* Only notify for port forwarding on 3000

* Allow access from localhost and shared github URLs.

* Change ownership

* Remove host header check

This was obviated by the addition of the HostAuthorization middleware in Rails 6

* Add test DB setup to main local settings file

* Update tests

* API-32311 establish poa oas updates (#16005)

* API-32311 establish poa oas updates

* Updates OAS text
* Updates Swagger Docs
	modified:   modules/claims_api/app/swagger/claims_api/description/v2.md
	modified:   modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json
	modified:   modules/claims_api/app/swagger/claims_api/v2/production/swagger.json

* Updates for removed text

* Fixes missed line removal

* Adds missed docs text update

* Adds 2122, 2122a, 212/vallidate, 2122a/validate and power-of-attorney/{id} endpoints to docs

* Add pension specific sentry tag (#16040)

* - Add pension specific sentry tag

* - Add pension specific sentry tag

* - Add pension specific sentry tag

* - Add pension specific sentry tag

---------

Co-authored-by: Scott Gorman <[email protected]>

* dbex/77177: EVSS Migration - /generatePDF migration: Abstract references to EVSS /getpdf (#16080)

* dbex/77177: add GeneratePdfProvider
- FEATURE TOGGLE: disability_compensation_lighthouse_generate_pdf
- evss
- lighthouse stub(s)
- unit tests

* dbex/77177: add GeneratePdfProvider
- fix linting and unit test

* dbex/77177: add GeneratePdfProvider
- fix linting and unit test

* dbex/77177: add GeneratePdfProvider
- added a unit test for evss service class checking

* [Bugfix] Personal health care contacts: Selects only valid contact types (#16062)

* Selects only valid contact types

* Updating version of REDIS to 6.2 in the docker compose files. (#16090)

* Authorized Ping Endpoint for Travel Pay API (#16089)

* Add authorized_ping endpoint to BTSSS API

* Adds specs for authorized ping endpoint, cleanup and bug fixes

* Fixes for rubocop

* Adds line comment

---------

Co-authored-by: Athif Wulandana <[email protected]>

* MBMS-61276 change UUID size and position on pre need form 40-10007 pdf (#16074)

* [#MHV-54372] remove 556 transition feature flags (#15990)

Co-authored-by: Alex Morgun <[email protected]>

* removed cache busting for mobile rx (#16099)

* removed cache busting for mobile rx

* removed failing test for mobile

* fixed gemfile

* Bump json-schema from 4.2.0 to 4.3.0

Bumps [json-schema](https://github.com/voxpupuli/json-schema) from 4.2.0 to 4.3.0.
- [Changelog](https://github.com/voxpupuli/json-schema/blob/master/CHANGELOG.md)
- [Commits](voxpupuli/json-schema@v4.2.0...v4.3.0)

---
updated-dependencies:
- dependency-name: json-schema
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* update deprecated code

* Added s3 check to specific appeals endpoint that use  s3 (#16034)

Co-authored-by: Matt Kelly <[email protected]>

* Update Faker::IDNumber to Faker::IdNumber (#16102)

* Api 33483 poa v2 signatures (#15406)

* Make reg num required

* Add sig to PDF

* Add .first test

* Handle duplicate reps by ID

* Require rep_id in builder

* Adding facility_type in CIE Logger util (#16083)

Co-authored-by: kanchanasuriya <[email protected]>

* MHV-56068: Serialize tracking_list as 1-level array (#16056)

* Add serlization for `tracking_list`, tests

* Update/fix test for tracking_list and the first tracking item

* Add trackingList item to openapi schema

* Add separate PrescriptionTrackingItem schema, update PrescriptionDetail
to reference

* Mobile: Remove logs (#16068)

* Remove logs

* rubocop

* Add back logging that is occurring

* Remove logging from tests

---------

Co-authored-by: Tonksthebear <[email protected]>

* Add additional logging in case of Pension errors (#16065)

* Add additional logging in case of Pension errors

* Fix lint errors

* Handle no error message, fix test

* Update codeowwners

* Move logging to separate class

* Update test

* Fix lint

* 76818: Change config for NodEmailLoaderJob to use a hash (#16109)

* 79457 handle ICN for OH data (#16119)

* fixed linter issues

* added changes to openapi_merged.yaml

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Adrian Rollett <[email protected]>
Co-authored-by: Rockwell Windsor Rice <[email protected]>
Co-authored-by: Scott <[email protected]>
Co-authored-by: Scott Gorman <[email protected]>
Co-authored-by: Aurora <[email protected]>
Co-authored-by: Richard Davis <[email protected]>
Co-authored-by: Joshua Backfield <[email protected]>
Co-authored-by: Athif Wulandana <[email protected]>
Co-authored-by: Athif Wulandana <[email protected]>
Co-authored-by: Adam Antonioli <[email protected]>
Co-authored-by: Alex Morgun <[email protected]>
Co-authored-by: Alex Morgun <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Lindsey Hattamer <[email protected]>
Co-authored-by: Mike <[email protected]>
Co-authored-by: Matt Kelly <[email protected]>
Co-authored-by: stevenjcumming <[email protected]>
Co-authored-by: Austin Covrig <[email protected]>
Co-authored-by: kanchanasuriya <[email protected]>
Co-authored-by: kanchanasuriya <[email protected]>
Co-authored-by: Daniel Cloud <[email protected]>
Co-authored-by: Jason C <[email protected]>
Co-authored-by: Tonksthebear <[email protected]>
Co-authored-by: Tai Wilkin-Corraggio <[email protected]>
Co-authored-by: dfong-adh <[email protected]>
Co-authored-by: Gaurav Gupta <[email protected]>
@Jessica-Downs-Bowen
Copy link

Commenting to maintain my access

2 similar comments
@Jessica-Downs-Bowen
Copy link

Commenting to maintain my access

@Jessica-Downs-Bowen
Copy link

Commenting to maintain my access

@Jessica-Downs-Bowen
Copy link

Commenting to maintain my access

5 similar comments
@Jessica-Downs-Bowen
Copy link

Commenting to maintain my access

@Jessica-Downs-Bowen
Copy link

Commenting to maintain my access

@Jessica-Downs-Bowen
Copy link

Commenting to maintain my access

@Jessica-Downs-Bowen
Copy link

Commenting to maintain my access

@Jessica-Downs-Bowen
Copy link

Commenting to maintain my access

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants