Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

78648 do not call refresh_appts for OH claims #16073

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

randomsync
Copy link
Member

@randomsync randomsync commented Mar 25, 2024

Summary

For OH sites, there's no concept of "check in" currently, and so there's no concept of refresh appointments and those calls will fail if made. This PR checks the incoming parameter for facility_type = OH, and doesn't call CHIP's refresh_appointments for that case.

  • This work is behind a feature toggle (flipper): NO

Related issue(s)

Testing done

  • rspecs
  • local testing

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

Copy link
Contributor

@kanchanasuriya kanchanasuriya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@randomsync randomsync merged commit 729fc84 into master Mar 25, 2024
20 checks passed
@randomsync randomsync deleted the 78648_no_refresh_appts_for_OH_travel_claims branch March 25, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants