Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Shaun Burdick to Decision Reviews email list #16069

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

caseywilliams
Copy link
Contributor

Summary

Slack thread

Related issue(s)

None

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@caseywilliams caseywilliams added Lighthouse lighthouse appeals Lighthouse API appeals banana-peels Lighthouse Banana Peels Team labels Mar 25, 2024
@caseywilliams caseywilliams requested a review from a team as a code owner March 25, 2024 17:42
@caseywilliams caseywilliams force-pushed the add-shaun-burdick-to-email-list branch from 10069fd to a9de1ba Compare March 25, 2024 17:43
@va-vfs-bot va-vfs-bot temporarily deployed to add-shaun-burdick-to-email-list/main/main March 25, 2024 18:06 Inactive
@caseywilliams caseywilliams force-pushed the add-shaun-burdick-to-email-list branch from a9de1ba to 783e295 Compare March 25, 2024 18:09
@caseywilliams caseywilliams merged commit 59181c2 into master Mar 25, 2024
20 checks passed
@caseywilliams caseywilliams deleted the add-shaun-burdick-to-email-list branch March 25, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appeals Lighthouse API appeals banana-peels Lighthouse Banana Peels Team Lighthouse lighthouse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants