Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DR-74493] fix pdf validation config in prod #16067

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

anniebtran
Copy link
Contributor

Summary

This feature is controlled by a backend setting that is enabled in staging but not prod (yet): Settings.decision_review.pdf_validation.enabled

This fixes the configuration used in the proxy service that was previously built but never fully switched on (see more details here) — we are now ready to use it, so I've been trying to fix the configurations to make sure it all works as expected.

I recently learned that we are able to use the Decision Reviews API key in dev and staging as originally designed (through this service's configuration inheriting the DR configuration) — but it didn't work in production when I tried making some test calls using the DR prod API key. The test calls did work when I used prod's Benefits Intake API key, so I've added a conditional to use the proper API key in production

Related issue(s)

department-of-veterans-affairs/va.gov-team#74493

Testing done

  • Tested that dev still works as it previously did, will also check in staging
  • Checked that Settings.benefits_intake_service.api_key || Settings.form526_backup.api_key returns the proper API key in production. Will check in production that API call using service works before enabling the feature

What areas of the site does it impact?

Appeals Backend (on a feature that is not enabled in production yet)

Acceptance criteria

  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@anniebtran anniebtran merged commit 76a84f6 into master Mar 26, 2024
20 checks passed
@anniebtran anniebtran deleted the DR-74493-fix-pdf-validation-config-in-prod branch March 26, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants