-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api 33481 poa v2 ind signatures #16064
Conversation
@@ -221,6 +221,7 @@ | |||
"additionalProperties": false, | |||
"required": [ | |||
"poaCode", | |||
"registrationNumber", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could probably remove first and last name from here. That would require adding them back into the form data like what you did for 2122.
modules/claims_api/spec/fixtures/v2/veterans/power_of_attorney/2122a/valid.json
Show resolved
Hide resolved
@@ -70,7 +68,8 @@ def validate_registration_number!(form_number) | |||
rn).order(created_at: :desc).first | |||
if rep.nil? | |||
raise ::Common::Exceptions::ResourceNotFound.new( | |||
detail: "Could not retrieve Power of Attorney with registration number: #{rn} and poa code: #{poa_code}" | |||
detail: "Could not find an Accredited Representative with registration number: #{rn} " \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I like this language update
Summary
Related issue(s)
Testing done
What areas of the site does it impact?
v2 individual POA
Acceptance criteria