Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api 33481 poa v2 ind signatures #16064

Merged
merged 43 commits into from
Apr 1, 2024
Merged

Conversation

acovrig
Copy link
Contributor

@acovrig acovrig commented Mar 25, 2024

Summary

  • Require registrationNumber
  • Validate regNum
  • Add the signature to the generated PDF

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

What areas of the site does it impact?

v2 individual POA

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@acovrig acovrig added the claimsApi modules/claims_api label Mar 25, 2024
@acovrig acovrig self-assigned this Mar 25, 2024
@acovrig acovrig requested a review from a team as a code owner March 25, 2024 15:38
@va-vfs-bot va-vfs-bot temporarily deployed to API-33481-poa-v2-ind-signatures/main/main March 25, 2024 15:45 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-33481-poa-v2-ind-signatures/main/main March 25, 2024 15:57 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-33481-poa-v2-ind-signatures/main/main March 26, 2024 14:40 Inactive
@@ -221,6 +221,7 @@
"additionalProperties": false,
"required": [
"poaCode",
"registrationNumber",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could probably remove first and last name from here. That would require adding them back into the form data like what you did for 2122.

@@ -70,7 +68,8 @@ def validate_registration_number!(form_number)
rn).order(created_at: :desc).first
if rep.nil?
raise ::Common::Exceptions::ResourceNotFound.new(
detail: "Could not retrieve Power of Attorney with registration number: #{rn} and poa code: #{poa_code}"
detail: "Could not find an Accredited Representative with registration number: #{rn} " \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like this language update

@acovrig acovrig merged commit af48340 into master Apr 1, 2024
20 checks passed
@acovrig acovrig deleted the API-33481-poa-v2-ind-signatures branch April 1, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimsApi modules/claims_api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants