-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1115] poc: add logic to verify a PDF was properly stamped #16051
[1115] poc: add logic to verify a PDF was properly stamped #16051
Conversation
10d2553
to
0df0920
Compare
972ade9
to
d0aa44a
Compare
d0aa44a
to
66810b6
Compare
66810b6
to
1aa35dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment and I think tests are not passing quite yet. Otherwise I'd approve! Great work!
modules/simple_forms_api/app/services/simple_forms_api/pdf_stamper.rb
Outdated
Show resolved
Hide resolved
modules/simple_forms_api/app/services/simple_forms_api/pdf_stamper.rb
Outdated
Show resolved
Hide resolved
ffda376
to
e920bb1
Compare
1e8b876
to
795fa03
Compare
Generated by 🚫 Danger |
a619e07
to
bf17321
Compare
bf17321
to
d0cc5df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for updating all those fixtures. I'm really excited to roll this out and see it in action! 😃
d0cc5df
to
00a3b0d
Compare
Summary
Related issue(s)
department-of-veterans-affairs/VA.gov-team-forms#1115
Testing done
Screenshots
Note: Optional
What areas of the site does it impact?
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?