Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1115] poc: add logic to verify a PDF was properly stamped #16051

Merged
merged 15 commits into from
Mar 26, 2024

Conversation

pennja
Copy link
Contributor

@pennja pennja commented Mar 22, 2024

Summary

  • This work is behind a feature toggle (flipper): NO
  • Added a lambda method which verifies when a stamp has successfully been applied to a pdf
  • Added test coverage surrounding new logic
  • Updated existing test coverage for the pdf_stamper class to align with RSpec patterns

Related issue(s)

  • Link to ticket created in va.gov-team repo OR screenshot of Jira ticket if your team uses Jira
    department-of-veterans-affairs/VA.gov-team-forms#1115

Testing done

  • New code is covered by unit tests

Screenshots

Note: Optional

What areas of the site does it impact?

  • PDF Stamping and Filling

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to jap/simple-forms/pdf-stamp-verification-spike-2/main/main March 22, 2024 11:41 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to jap/simple-forms/pdf-stamp-verification-spike-2/main/main March 22, 2024 11:53 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to jap/simple-forms/pdf-stamp-verification-spike-2/main/main March 22, 2024 12:14 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to jap/simple-forms/pdf-stamp-verification-spike-2/main/main March 22, 2024 13:24 Inactive
@pennja pennja force-pushed the jap/simple-forms/pdf-stamp-verification-spike-2 branch 2 times, most recently from 10d2553 to 0df0920 Compare March 22, 2024 14:57
@va-vfs-bot va-vfs-bot temporarily deployed to jap/simple-forms/pdf-stamp-verification-spike-2/main/main March 22, 2024 15:02 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to jap/simple-forms/pdf-stamp-verification-spike-2/main/main March 22, 2024 15:22 Inactive
@pennja pennja marked this pull request as ready for review March 22, 2024 20:23
@pennja pennja requested review from a team as code owners March 22, 2024 20:23
@pennja pennja requested a review from Thrillberg March 22, 2024 20:23
@pennja pennja force-pushed the jap/simple-forms/pdf-stamp-verification-spike-2 branch from 972ade9 to d0aa44a Compare March 22, 2024 20:25
@va-vfs-bot va-vfs-bot temporarily deployed to jap/simple-forms/pdf-stamp-verification-spike-2/main/main March 22, 2024 20:32 Inactive
@pennja pennja force-pushed the jap/simple-forms/pdf-stamp-verification-spike-2 branch from d0aa44a to 66810b6 Compare March 25, 2024 12:51
@va-vfs-bot va-vfs-bot temporarily deployed to jap/simple-forms/pdf-stamp-verification-spike-2/main/main March 25, 2024 12:52 Inactive
@pennja pennja force-pushed the jap/simple-forms/pdf-stamp-verification-spike-2 branch from 66810b6 to 1aa35dd Compare March 25, 2024 13:10
@va-vfs-bot va-vfs-bot temporarily deployed to jap/simple-forms/pdf-stamp-verification-spike-2/main/main March 25, 2024 13:11 Inactive
Copy link
Contributor

@Thrillberg Thrillberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment and I think tests are not passing quite yet. Otherwise I'd approve! Great work!

@va-vfs-bot va-vfs-bot temporarily deployed to jap/simple-forms/pdf-stamp-verification-spike-2/main/main March 25, 2024 15:17 Inactive
@pennja pennja force-pushed the jap/simple-forms/pdf-stamp-verification-spike-2 branch from ffda376 to e920bb1 Compare March 25, 2024 15:56
@va-vfs-bot va-vfs-bot temporarily deployed to jap/simple-forms/pdf-stamp-verification-spike-2/main/main March 25, 2024 16:09 Inactive
@pennja pennja force-pushed the jap/simple-forms/pdf-stamp-verification-spike-2 branch from 1e8b876 to 795fa03 Compare March 25, 2024 20:36
Copy link

1 Warning
⚠️ This PR changes 205 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • modules/simple_forms_api/app/services/simple_forms_api/pdf_stamper.rb (+33/-18)

  • modules/simple_forms_api/spec/services/pdf_filler_spec.rb (+3/-0)

  • modules/simple_forms_api/spec/services/pdf_stamper_spec.rb (+138/-13)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

Copy link
Contributor

@Thrillberg Thrillberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for updating all those fixtures. I'm really excited to roll this out and see it in action! 😃

@pennja pennja force-pushed the jap/simple-forms/pdf-stamp-verification-spike-2 branch from d0cc5df to 00a3b0d Compare March 26, 2024 12:50
@pennja pennja merged commit 58d8519 into master Mar 26, 2024
20 checks passed
@pennja pennja deleted the jap/simple-forms/pdf-stamp-verification-spike-2 branch March 26, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants