Ndbex 70721 map form fields

[evansmith]

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

• This work is behind a feature toggle (flipper): YES va_burial_v2
• This change handles the backend updates for the V2 Burial form. Included in this PR are changes that address: Controller updates for InProgressForm and SavedClaim to redirect Burials to be considered a 21P-530V2 form instead of 21P-530, Model changes in SavedClaim and Burial that set form_id to 21P-530V2 based on a new flag passing in, and a new PDF with relevant pdf filler changes for the 21P-530V2 upgrade.
• (What is the solution, why is this the solution?)
• VA Benefits and Claims
• Targeting successful testing between vets-website and vets-api in the creation of v2 burial claims.
• This PR goes over the line limit due to the need to add a new file (lib/pdf_fill/forms/va21p530v2.rb) for the PDF Filler portion of 21P-530V2. That takes up the large majority of line changes while other changes in the controllers/models/spec are supplemental.

Related issue(s)

• Link to ticket created in va.gov-team repo OR screenshot of Jira ticket if your team uses Jira
  Burial PDF | Push in the new PDF and PdfFiller classes va.gov-team#70687
  Update Burial Controller to support 530EZ va.gov-team#77626
  Burial | Map form fields to new pdf va.gov-team#70721

Testing done

• New code is covered by unit tests
• Prior to the change, the 21P-530 PDF would be rendered and form_id on the SavedClaim and InProgressForms would be 21P-530.
• Fully test the creation of a Burial claim and examine the PDF to confirm that all relevant changes have been loaded. Additional Unit Tests have been created.
• If this work is behind a flipper:
  • What is the testing plan for rolling out the feature? Perform a staging review with the flippers on to confirm Burials have been fully updated.

Screenshots

Note: Optional

What areas of the site does it impact?

Burial form completion and associated PDF.

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog or Grafana (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

[tblackwe]

Reviewed in detail with Evan over several days. This version LGTM