Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CST] [DDL] [Backend] Updated the doctypes for 5103 notices in the DDL #15820

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

samcoforma
Copy link
Contributor

@samcoforma samcoforma commented Mar 6, 2024

Summary

  • Our team discovered that the doctypes for 5103 Notices were different than we thought they were. We also discovered an additional 5103 notice document and have added that into the allowed doctypes of the controller.

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@@ -34,8 +34,9 @@ def service
def allowed_doctypes
doctypes = %w[184]
doctypes << '27' if Flipper.enabled?(:cst_include_ddl_boa_letters, @current_user)
doctypes << '65' if Flipper.enabled?(:cst_include_ddl_5103_letters, @current_user)
doctypes << '68' if Flipper.enabled?(:cst_include_ddl_5103_letters, @current_user)
doctypes << '704' if Flipper.enabled?(:cst_include_ddl_5103_letters, @current_user)
Copy link
Contributor

@pmclaren19 pmclaren19 Mar 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im confused on why we are removing 65 and 68 and adding 704, 706, 858. If you could add some information about this to your ticket that'd be really helpful! I took a look at the link you provided here and it looks to me like we should be adding 704, 705 , 706 and 707 so im very confused. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked to @jacobworrell in parking lot

  • letter id 704 correlates to 65 and we were just referencing the wrong id#. It is for Standard 5103 Notice
  • letter id 706 correlates to 68 and we were just referencing the wrong id#. It is for 5103/ DTA letter
  • letter id 858 needed to be added and is for Custom 5103 Notice

Copy link
Contributor

@pmclaren19 pmclaren19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarified on context of the changes with @jacobworrell and added a note! Looks good.

@samcoforma samcoforma merged commit 07d01b6 into master Mar 7, 2024
21 checks passed
@samcoforma samcoforma deleted the 72464-DDL-5103-doctype-correction branch March 7, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants