-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CST] [DDL] [Backend] Updated the doctypes for 5103 notices in the DDL #15820
Conversation
@@ -34,8 +34,9 @@ def service | |||
def allowed_doctypes | |||
doctypes = %w[184] | |||
doctypes << '27' if Flipper.enabled?(:cst_include_ddl_boa_letters, @current_user) | |||
doctypes << '65' if Flipper.enabled?(:cst_include_ddl_5103_letters, @current_user) | |||
doctypes << '68' if Flipper.enabled?(:cst_include_ddl_5103_letters, @current_user) | |||
doctypes << '704' if Flipper.enabled?(:cst_include_ddl_5103_letters, @current_user) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im confused on why we are removing 65 and 68 and adding 704, 706, 858. If you could add some information about this to your ticket that'd be really helpful! I took a look at the link you provided here and it looks to me like we should be adding 704, 705 , 706 and 707 so im very confused. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talked to @jacobworrell in parking lot
- letter id 704 correlates to 65 and we were just referencing the wrong id#. It is for Standard 5103 Notice
- letter id 706 correlates to 68 and we were just referencing the wrong id#. It is for 5103/ DTA letter
- letter id 858 needed to be added and is for Custom 5103 Notice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarified on context of the changes with @jacobworrell and added a note! Looks good.
Summary
Related issue(s)
Testing done
Screenshots
Note: Optional
What areas of the site does it impact?
(Describe what parts of the site are impacted andifcode touched other areas)
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?