Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable user profile email in form 40-0247 #15818

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

ianperera
Copy link
Contributor

Summary

  • Form 40-0247's disabled for authentication and doesn't load user data for current session.
  • Decided to send confirmation email only when user fills in email field in the form

Related issue(s)

Testing done

  • New code is covered by unit tests

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@ianperera ianperera requested review from a team as code owners March 6, 2024 22:10
@ianperera ianperera added the bug label Mar 6, 2024
@ianperera ianperera merged commit 0ba2320 into master Mar 7, 2024
20 checks passed
@ianperera ianperera deleted the 1225-40_0247-form-trigger branch March 7, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants