Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

76255 travel claims oh templates 2 #15812

Merged
merged 8 commits into from
Mar 18, 2024

Conversation

randomsync
Copy link
Member

@randomsync randomsync commented Mar 6, 2024

Summary

This PR handles the selection of templates for travel claims for Oracle Health sites. The facility_type from LoROTA data specifies whether the facility is a vista facility or OH, and we choose the template based on that parameter.

Related issue(s)

Testing done

  • rspecs
  • local testing with vets-website

What areas of the site does it impact?

  • check_in experience

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Copy link

github-actions bot commented Mar 6, 2024

1 Warning
⚠️ This PR changes 288 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • config/settings.yml (+6/-0)

  • config/settings/test.yml (+10/-4)

  • modules/check_in/app/sidekiq/check_in/travel_claim_submission_worker.rb (+64/-28)

  • modules/check_in/spec/sidekiq/travel_claim_submission_worker_spec.rb (+88/-88)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@randomsync randomsync marked this pull request as ready for review March 7, 2024 00:31
@randomsync randomsync requested review from a team as code owners March 7, 2024 00:31
kanchanasuriya
kanchanasuriya previously approved these changes Mar 7, 2024
Copy link
Contributor

@kanchanasuriya kanchanasuriya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ryan-mcneil
ryan-mcneil previously approved these changes Mar 7, 2024
Copy link
Contributor

@ryan-mcneil ryan-mcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@randomsync randomsync dismissed stale reviews from ryan-mcneil and kanchanasuriya via 8137840 March 8, 2024 17:30
@randomsync randomsync force-pushed the 76255_travel_claims_oh_templates_2 branch from 9b3a9e9 to 8137840 Compare March 8, 2024 17:30
kanchanasuriya
kanchanasuriya previously approved these changes Mar 8, 2024
Copy link
Contributor

@kanchanasuriya kanchanasuriya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kanchanasuriya
kanchanasuriya previously approved these changes Mar 8, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to 76255_travel_claims_oh_templates_2/main/main March 8, 2024 18:21 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 76255_travel_claims_oh_templates_2/main/main March 14, 2024 21:58 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 76255_travel_claims_oh_templates_2/main/main March 18, 2024 16:26 Inactive
Copy link
Contributor

@ryan-mcneil ryan-mcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@randomsync randomsync merged commit ae2a15b into master Mar 18, 2024
29 checks passed
@randomsync randomsync deleted the 76255_travel_claims_oh_templates_2 branch March 18, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants