Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to enable direct deposit for education benefits #15804

Merged
merged 4 commits into from
Mar 6, 2024

Conversation

tpharrison
Copy link
Contributor

@tpharrison tpharrison commented Mar 6, 2024

Summary

Lighthouse will be adding an additional control flag (isEduClaimAvailable) to the Direct Deposit API GET response that will be used to determine if a user can add or update Direct Deposit for Education Benefits.

Related issue(s)

department-of-veterans-affairs/va.gov-team#76716

Testing done

Updated disability compensation controller specs.

@tpharrison tpharrison changed the title Add is_edu_claim_available flag which will be used to enable direct d… Add flag to enable direct deposit for education benefits Mar 6, 2024
@tpharrison tpharrison marked this pull request as ready for review March 6, 2024 16:43
@tpharrison tpharrison requested review from a team as code owners March 6, 2024 16:43
mchae-nava
mchae-nava previously approved these changes Mar 6, 2024
ryan-mcneil
ryan-mcneil previously approved these changes Mar 6, 2024
Copy link
Contributor

@ryan-mcneil ryan-mcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tpharrison tpharrison dismissed stale reviews from ryan-mcneil and mchae-nava via 9ca4c95 March 6, 2024 17:00
@tpharrison
Copy link
Contributor Author

@ryan-mcneil @mchae-nava I just added one additional spec. Do you mind giving it another review?

Copy link
Contributor

@ryan-mcneil ryan-mcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@tpharrison tpharrison merged commit b6e96b4 into master Mar 6, 2024
19 checks passed
@tpharrison tpharrison deleted the direct-deposit-add-edu-flag branch March 6, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants